Closed
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
==========================================
- Coverage 29.22% 29.17% -0.05%
==========================================
Files 49 49
Lines 17488 17554 +66
Branches 8457 8482 +25
==========================================
+ Hits 5110 5122 +12
- Misses 7252 7258 +6
- Partials 5126 5174 +48
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
drahnr
approved these changes
Apr 20, 2023
NobodyXu
force-pushed
the
rm-openssl-for-debug-build
branch
from
93a8b64 to
6f97da5
Compare
Contributor
Author
|
I've rebased against main, so this PR is now ready to merge. |
Collaborator
|
Seems that it broke one of the Ubuntu test |
NobodyXu
force-pushed
the
rm-openssl-for-debug-build
branch
from
6f97da5 to
199de56
Compare
Contributor
Author
Honestly, I have no idea why changing tls implementation would break |
Collaborator
I think a unit test might be in order to verify this more atomically |
NobodyXu
changed the title
NobodyXu
changed the title
Closed
Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
force-pushed
the
rm-openssl-for-debug-build
branch
from
199de56 to
68aea4e
Compare
Contributor
Author
|
Superseded by #1742 |
tottoto
added a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
* chore: Refactor redundant pattern match * chore: Refactor redundant closure style * chore(examples): Remove redundant type converting * chore(examples): Use rustls_pemfile::private_key to parse private key * chore(examples): Remove redundant CertificateDer::to_owned call * chore(examples): Create Routes directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #1737
Signed-off-by: Jiahao XU [email protected]