Stop feature dist-server from pulling in openssl#1738
Closed
NobodyXu wants to merge 2 commits intomozilla:mainfrom
Closed
Stop feature dist-server from pulling in openssl#1738NobodyXu wants to merge 2 commits intomozilla:mainfrom
NobodyXu wants to merge 2 commits intomozilla:mainfrom
Conversation
NobodyXu
force-pushed
the
rm-openssl-for-dist-server
branch
from
b4c8abd to
cfd4e2d
Compare
Contributor
Author
|
Build failure will be fixed once #1737 is merged |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
==========================================
+ Coverage 28.87% 29.11% +0.24%
==========================================
Files 49 49
Lines 17202 17446 +244
Branches 8268 8455 +187
==========================================
+ Hits 4967 5080 +113
- Misses 7221 7301 +80
- Partials 5014 5065 +51 see 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
The CI failure is caused by spki (pulled in pkcs1). Its msrv is 1.65 while currently sccache has a msrv of 1.64, thus requires a bump of msrv. |
- Replace direct `openssl` usage in sccache-dist/token_check.rs with `pkcs1` - Enable `rouille/rustls` instead of `rouille/ssl` to use rustls instead of openssl in tiny_http (dep of rouille). Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
force-pushed
the
rm-openssl-for-dist-server
branch
from
cfd4e2d to
b9b3595
Compare
Signed-off-by: Jiahao XU <[email protected]>
Contributor
Author
|
Blocked on tomaka/rouille#272 |
Collaborator
|
I'd say porting to warp (see #1620 ) should avoid the issue and move to a more modern framework |
Contributor
Author
Thanks for the advice! |
Contributor
Author
|
I will close this PR for now. |
NobodyXu
added a commit
to NobodyXu/sccache
that referenced
this pull request
Apr 21, 2023
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <[email protected]>
Closed
NobodyXu
added a commit
to NobodyXu/sccache
that referenced
this pull request
Apr 21, 2023
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
added a commit
to NobodyXu/sccache
that referenced
this pull request
Apr 21, 2023
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
added a commit
to NobodyXu/sccache
that referenced
this pull request
Apr 21, 2023
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
added a commit
to NobodyXu/sccache
that referenced
this pull request
Apr 21, 2023
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
added a commit
to NobodyXu/sccache
that referenced
this pull request
Apr 22, 2023
This is split from mozilla#1738 , to remove dependency on `openssl` in `src/bin/sccache-dist/token_check.rs`. Signed-off-by: Jiahao XU <[email protected]>
tottoto
added a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opensslusage in sccache-dist/token_check.rs withpkcs1rouille/rustlsinstead ofrouille/sslto use rustls instead of openssl in tiny_http (dep of rouille).opensslthat get pulled in debug buildSigned-off-by: Jiahao XU [email protected]