Conversation
|
should we manage the HUP signal ? |
|
We could and should, but I think that's a separate concern for another PR and requires some additional logic |
sylvestre
force-pushed
the
bernhard-port-cachepot-139
branch
from
1e0424e to
bec3a64
Compare
|
makes sense |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1629 +/- ##
==========================================
+ Coverage 29.44% 29.52% +0.07%
==========================================
Files 49 49
Lines 17713 17713
Branches 8544 8547 +3
==========================================
+ Hits 5216 5229 +13
+ Misses 7348 7340 -8
+ Partials 5149 5144 -5 ☔ View full report in Codecov by Sentry. |
* Handle signals in dist * Adds a comment
sylvestre
force-pushed
the
bernhard-port-cachepot-139
branch
from
bec3a64 to
2cc624e
Compare
|
|
||
| // Whenever `docker` or `systemd` stop the service, the signals | ||
| // have to be processed and the app has to perform a graceful stop. | ||
| select! { |
There was a problem hiding this comment.
By the default select will randomly pick the order of polling. You can make it use the order you have specified (also avoiding calling random) by adding biased.
I'm on my mobile but it should look something like this:
| select! { | |
| select! { | |
| biased; | |
|
I'll get back to this eventually |
|
thanks :) |
5 participants
Handles signals in dist mode by adding them as a future and
select!.Ref #1620
Orignal work by @montekki