Closed
Conversation
Author
|
Accidentally included the changes from my other PR. I have reverted them in my latest commit so this PR should just be a couple of extra lines of documentation. |
Contributor
|
Rebased and landed as c596150 Thanks for the patch! At some point I think I'd like to break the documentation for each storage backend out to a separate .md file, but documenting undocumented things is always an improvement. |
drahnr
pushed a commit
that referenced
this pull request
Feb 27, 2023
* Handle signals in dist * Adds a comment
sylvestre
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Handle signals in dist * Adds a comment
drahnr
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Handle signals in dist * Adds a comment
sylvestre
pushed a commit
that referenced
this pull request
Mar 20, 2023
* Handle signals in dist * Adds a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor addition for undocumented s3 env variables needed to use a private s3 compatible object store like minio.