Use different hashing functions for different file types#1135
Merged
mitchhentges merged 2 commits intomozilla:mainfrom Mar 3, 2022
Merged
Use different hashing functions for different file types#1135mitchhentges merged 2 commits intomozilla:mainfrom
mitchhentges merged 2 commits intomozilla:mainfrom
Conversation
This adds a new special hasher for static libraries, which contain timestamps and other info that prevent them from being cachable in some cases.
Codecov Report
@@ Coverage Diff @@
## main #1135 +/- ##
===========================================
- Coverage 57.81% 34.50% -23.32%
===========================================
Files 47 47
Lines 12107 12472 +365
Branches 2184 6487 +4303
===========================================
- Hits 7000 4303 -2697
- Misses 3727 4097 +370
- Partials 1380 4072 +2692
Continue to review full report at Codecov.
|
mitchhentges
approved these changes
Mar 2, 2022
Contributor
mitchhentges
left a comment
mitchhentges
left a comment
There was a problem hiding this comment.
Looks good, but I'd prefer if we updated the "Unix archive" comment if possible.
Thanks for rebasing this patch!
Co-authored-by: Mitchell Hentges <[email protected]>
Contributor
|
Thanks again for rebasing this, great work! Let's get it landed :) |
emabrey
pushed a commit
to emabrey/sccache
that referenced
this pull request
Aug 10, 2022
* Use different hashing functions for different file types This adds a new special hasher for static libraries, which contain timestamps and other info that prevent them from being cachable in some cases. * Update src/util.rs Co-authored-by: Mitchell Hentges <[email protected]> Co-authored-by: Jack Moffitt <[email protected]> Co-authored-by: Mitchell Hentges <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new special hasher for static libraries, which contain timestamps and other info that prevent them from being cachable in some cases.