Skip to content

ArgInfo::cmp does not account for CanBeConcatenated, fails to parse -fplugin=foo.so #2505

@2over12

Description

@2over12

In observing spurious cache hits for -fplugin=foo.so when foo.so changed we realized foo.so was not in the extra hash files.

The root cause here is that cmp does not account for arguments declared CanBeConcatenated like fplugin.

This can be observed in this failing test case: https://github.com/2over12/sccache/blob/6e423c58d8806bafb4dcb42137f330e61b991450/src/compiler/clang.rs#L938

I also dont think -fplugin x is valid for clang so this could potentially be Concatenated

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions