Skip to content

Commit e548aed

Browse files
committed
Fix clippy warnings
1 parent 090767f commit e548aed

3 files changed

Lines changed: 11 additions & 27 deletions

File tree

‎src/metrics/cognitive.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ macro_rules! nesting_levels {
182182
#[derive(Debug, Default, Clone)]
183183
struct BoolSequence {
184184
boolean_op: Option<u16>,
185-
first_boolean: bool,
186185
}
187186

188187
impl BoolSequence {

‎src/ops.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,23 +107,23 @@ fn finalize<T: ParserTrait>(state_stack: &mut Vec<State>, diff_level: usize) {
107107

108108
// If there is only the unit space
109109
if state_stack.len() == 1 {
110-
let mut last_state = state_stack.last_mut().unwrap();
110+
let last_state = state_stack.last_mut().unwrap();
111111
// Compute last_state operators and operands
112-
compute_operators_and_operands::<T>(&mut last_state);
112+
compute_operators_and_operands::<T>(last_state);
113113
}
114114

115115
for _ in 0..diff_level {
116116
if state_stack.len() == 1 {
117117
break;
118118
} else {
119119
let mut state = state_stack.pop().unwrap();
120-
let mut last_state = state_stack.last_mut().unwrap();
120+
let last_state = state_stack.last_mut().unwrap();
121121

122122
// Compute state operators and operands
123123
compute_operators_and_operands::<T>(&mut state);
124124

125125
// Compute last_state operators and operands
126-
compute_operators_and_operands::<T>(&mut last_state);
126+
compute_operators_and_operands::<T>(last_state);
127127

128128
// Merge Halstead maps
129129
last_state.halstead_maps.merge(&state.halstead_maps);

‎src/spaces.rs‎

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ impl fmt::Display for SpaceKind {
5757
}
5858

5959
/// All metrics data.
60-
#[derive(Debug, Clone, Serialize)]
60+
#[derive(Default, Debug, Clone, Serialize)]
6161
pub struct CodeMetrics {
6262
/// `NArgs` data
6363
pub nargs: nargs::Stats,
@@ -76,21 +76,6 @@ pub struct CodeMetrics {
7676
pub mi: mi::Stats,
7777
}
7878

79-
impl Default for CodeMetrics {
80-
fn default() -> Self {
81-
Self {
82-
cognitive: cognitive::Stats::default(),
83-
cyclomatic: cyclomatic::Stats::default(),
84-
halstead: halstead::Stats::default(),
85-
loc: loc::Stats::default(),
86-
nom: nom::Stats::default(),
87-
mi: mi::Stats::default(),
88-
nargs: nargs::Stats::default(),
89-
nexits: exit::Stats::default(),
90-
}
91-
}
92-
}
93-
9479
impl fmt::Display for CodeMetrics {
9580
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
9681
writeln!(f, "{}", self.nargs)?;
@@ -210,20 +195,20 @@ fn finalize<T: ParserTrait>(state_stack: &mut Vec<State>, diff_level: usize) {
210195
}
211196
for _ in 0..diff_level {
212197
if state_stack.len() == 1 {
213-
let mut last_state = state_stack.last_mut().unwrap();
214-
compute_minmax(&mut last_state);
215-
compute_halstead_and_mi::<T>(&mut last_state);
216-
compute_averages(&mut last_state);
198+
let last_state = state_stack.last_mut().unwrap();
199+
compute_minmax(last_state);
200+
compute_halstead_and_mi::<T>(last_state);
201+
compute_averages(last_state);
217202
break;
218203
} else {
219204
let mut state = state_stack.pop().unwrap();
220205
compute_minmax(&mut state);
221206
compute_halstead_and_mi::<T>(&mut state);
222207
compute_averages(&mut state);
223208

224-
let mut last_state = state_stack.last_mut().unwrap();
209+
let last_state = state_stack.last_mut().unwrap();
225210
last_state.halstead_maps.merge(&state.halstead_maps);
226-
compute_halstead_and_mi::<T>(&mut last_state);
211+
compute_halstead_and_mi::<T>(last_state);
227212

228213
// Merge function spaces
229214
last_state.space.metrics.merge(&state.space.metrics);

0 commit comments

Comments
 (0)