Footer style updates (Fix #1063)#1064
Merged
Merged
Conversation
- Grey headers - Horiztonal line on mobile - Larger font for legal - Terms are a vertical list at smallest screen size - Tweaks to spacing
stephaniehobson
added
Review: XS
maureenlholland
approved these changes
May 14, 2025
maureenlholland
left a comment
maureenlholland
left a comment
Collaborator
There was a problem hiding this comment.
Checked across breakpoints & with/without JS. LGTM! r+wc 🦶
1 request for comment clarification & 1 question around link hover styles
|
|
||
| ## Migration Tips | ||
|
|
||
| * Un-customized implementations of the footer will not break. If you have made customizations review it at all breakpoints. |
| clear: both; | ||
| color: $color-white; | ||
| margin: 0; | ||
| padding-top: $spacing-lg; |
| a:visited { | ||
| color: $color-light-gray-50; | ||
|
|
||
| &:hover, |
Collaborator
There was a problem hiding this comment.
non-blocking: is the hover/active/focus text-decoration rule necessary here? It seems to already be covered by default link styles
| // Footer secondary contains language selector, social icons, legal, and license | ||
|
|
||
| .mzp-c-footer-secondary { | ||
| @include text-body-xs; |
Co-authored-by: maureenlholland <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CHANGELOG.md.Issue
Fix #1061
Fix #1063
Testing
http://localhost:3000/components/detail/footer
http://localhost:3000/components/detail/example-basic
https://colourcontrast.cc/?background=000000&foreground=bfbfc9
Before and after: