Repository navigation
Fix the [Object] param entry in createAndAddNewEditor and three similar slips - #21850
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21850 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01%
==========================================
Files 264 264
Lines 67285 67285
==========================================
- Hits 60746 60744 -2
- Misses 6539 6541 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one in
annotation_editor_layeris the interesting one: the brackets sit around the type rather than the name, so jsdoc reads a parameter literally calledObjectanddataends up undocumented.recordOperationlooks like it picked up the second entry fromrecordNamedDependencyright above it. I left the underscore-prefixed unused args and theworkerPortsetters alone.