Skip to content

Add select filter #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ogonkov wants to merge 6 commits into from
Closed

Add select filter #1278

ogonkov wants to merge 6 commits into from

Conversation

@ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Mar 29, 2020 •
edited
Loading

Summary

Proposed change:

Closes #282 .

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@codecov-io
Copy link

codecov-io commented Mar 29, 2020 •
edited
Loading

Codecov Report

Merging #1278 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
+ Coverage   89.53%   89.55%   +0.01%     
==========================================
  Files          22       22              
  Lines        3020     3025       +5     
==========================================
+ Hits         2704     2709       +5     
  Misses        316      316
Impacted Files Coverage Δ
nunjucks/src/filters.js 96.18% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8eae5...5bc5a18. Read the comment docs.

@ogonkov ogonkov mentioned this pull request Mar 29, 2020
Merged
4 tasks
@ogonkov
Copy link
Contributor Author

ogonkov commented Apr 2, 2020

@fdintino can you look at this one pls?

@fdintino
Copy link
Collaborator

fdintino commented Apr 2, 2020

I've merged this into master, but github appears to be having some sort of service outage so it's not yet being reflected in the UI. I'll hold off temporarily on merging your reject filter PR.

1 similar comment
@fdintino
Copy link
Collaborator

fdintino commented Apr 2, 2020

I've merged this into master, but github appears to be having some sort of service outage so it's not yet being reflected in the UI. I'll hold off temporarily on merging your reject filter PR.

@ogonkov
Copy link
Contributor Author

ogonkov commented Apr 2, 2020

reject filter is not ready yet to be merged

@fdintino
Copy link
Collaborator

fdintino commented Apr 2, 2020

Ah, right. Thanks for this PR! Merged in 2031bf2

@fdintino fdintino closed this Apr 2, 2020
@BitcoinOutput BitcoinOutput mentioned this pull request Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement select/reject

3 participants

@ogonkov @codecov-io @fdintino