This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Release channels and M2M for country and locale #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug 1248265.
mythmon
force-pushed
the
version-filtering-1248265
branch
from
22d6994 to
0bbea9f
Compare
mythmon
changed the title
Fixes bug 1248263.
mythmon
force-pushed
the
version-filtering-1248265
branch
from
0bbea9f to
060dae7
Compare
Contributor
Author
|
The release channel change and the M2M changes for country and locale share a lot in common. It was much easier to combine them into one branch, so I did that. |
normandy/classifier/models.py
Outdated
| self.request = request | ||
| self.locale = locale | ||
| self.release_channel = release_channel | ||
| self._country = country |
Contributor
There was a problem hiding this comment.
You can actually just set self.country = country and it will use that instead of the cached property. So setting it if country isn't None will let you retain the decorator while allowing it to be set manually.
Contributor
|
r+wc, nice work! |
mythmon
pushed a commit
that referenced
this pull request
Feb 25, 2016
Release channels and M2M for country and locale
mythmon
pushed a commit
to mythmon/normandy
that referenced
this pull request
Jan 5, 2017
Bug 1325797: Do not fail if the dev-mode pref is missing on startup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Osmose r?