Strict Validation Mode Added#64
Merged
zaach merged 2 commits intomozilla:masterfrom Jun 1, 2015
Merged
Conversation
added 2 commits
January 24, 2015 20:08
1. Added a Strict Validation mode. If set to true, any properties specified in config files that are not declared in the schema will result in errors. This is to ensure that the schema and the config files are in sync. This brings convict further in line with the concept of a “Schema”. By default the strict mode is set to false. 2. Added test cases for strict mode
1. Added a fix for nested validation checks. 2. Modified test case schema and config files.
|
This is a pretty nice feature and would love to get it merged. Any chance for this to happen anytime soon? cc: @zaach |
Collaborator
|
I agree it is in line with the concept of "schema" featured in |
Contributor
|
👍 I like it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specified in config files that are not declared in the schema will
result in errors. This is to ensure that the schema and the config
files are in sync. This brings convict further in line with the concept
of a “Schema”. By default the strict mode is set to false.