pyproject: fully migrate to pyproject.toml from setup.py (bug 1917431)#1813
pyproject: fully migrate to pyproject.toml from setup.py (bug 1917431)#1813zzzeid merged 3 commits intomozilla:mainfrom
Conversation
Did not remove setup.py as black requires one. (Followng the compatibility block in https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html)
saschanaz
force-pushed
the
bug1917431
branch
from
79992e6 to
3f9ffb7
Compare
saschanaz
changed the title
saschanaz
changed the title
zzzeid
changed the title
pyproject.toml
Outdated
| [project.optional-dependencies] | ||
| dev = [ | ||
| "coverage==7.6.1", | ||
| "coveralls==4.0.1", | ||
| "mock==5.1.0", | ||
| "pytest==8.3.2", | ||
| "pytest-mock==3.14.0", | ||
| ] | ||
| gui = [ | ||
| "PySide6==6.6.*", | ||
| ] | ||
| gui-dev = [ | ||
| "pytest-qt==4.4.0", | ||
| ] | ||
| linters = [ | ||
| "flake8>=6.0.0", | ||
| "flake8-black", | ||
| "glean-parser", | ||
| "isort", | ||
| "mccabe", | ||
| "pyflakes", | ||
| ] |
There was a problem hiding this comment.
I think for the most part, this section of the code will not actually be used and adding it might make it harder to maintain these lists. E.g., the "gui" is built via pyinstaller, and distributed via GitHub in CI (based on the requirements files), and the dev/linters is also installed the same way. What do you think?
There was a problem hiding this comment.
That depends on what package manager is used, but given the recommended installation is to use the requirements.txt, I think we can skip this here.
| long_desc = """Regression range finder for Mozilla nightly builds. | ||
| For more information see the mozregression website: | ||
| http://mozilla.github.io/mozregression/""" |
There was a problem hiding this comment.
Looks like this was dropped? It could result in more blankness on the main PyPI page.
There was a problem hiding this comment.
pyproject somehow does not support this anymore and accepts readme instead 👀 (line 28)
| long_desc = """Regression range finder for Mozilla nightly builds. | ||
| For more information see the mozregression website: | ||
| http://mozilla.github.io/mozregression/""" |
There was a problem hiding this comment.
pyproject somehow does not support this anymore and accepts readme instead 👀 (line 28)
pyproject.toml
Outdated
| [project.optional-dependencies] | ||
| dev = [ | ||
| "coverage==7.6.1", | ||
| "coveralls==4.0.1", | ||
| "mock==5.1.0", | ||
| "pytest==8.3.2", | ||
| "pytest-mock==3.14.0", | ||
| ] | ||
| gui = [ | ||
| "PySide6==6.6.*", | ||
| ] | ||
| gui-dev = [ | ||
| "pytest-qt==4.4.0", | ||
| ] | ||
| linters = [ | ||
| "flake8>=6.0.0", | ||
| "flake8-black", | ||
| "glean-parser", | ||
| "isort", | ||
| "mccabe", | ||
| "pyflakes", | ||
| ] |
There was a problem hiding this comment.
That depends on what package manager is used, but given the recommended installation is to use the requirements.txt, I think we can skip this here.
Co-authored-by: Zeid Zabaneh <[email protected]>
2 participants
Did not remove setup.py as black requires one. (Followng the compatibility block in https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html)
Restricting to
setuptools>=61as it's the first version supporting pyproject.Restricting to
requires-python = ">= 3.8.1"as flake8 complained about mismatching python requirement.