Skip to content

Comments

cli, fetch_configs, gui: use arch to construct build regex (bug 1917418)#1812

Merged
zzzeid merged 3 commits intomozilla:mainfrom
saschanaz:bug1917418
Oct 3, 2024
Merged

cli, fetch_configs, gui: use arch to construct build regex (bug 1917418)#1812
zzzeid merged 3 commits intomozilla:mainfrom
saschanaz:bug1917418

Conversation

@saschanaz
Copy link
Contributor

No description provided.

@saschanaz saschanaz force-pushed the bug1917418 branch 2 times, most recently from 769edf6 to a41d980 Compare September 7, 2024 20:46
@saschanaz saschanaz changed the title fetch_configs: use arch to construct build regex (bug 1917418) cli, fetch_configs, gui: use arch to construct build regex (bug 1917418) Sep 7, 2024
Copy link
Collaborator

@zzzeid zzzeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Few minor comments. If you'd like to test a release of this (e.g., for mozregression-gui), let me know, I can trigger a full "dev" build.



def get_build_regex(name, os, bits, processor, platprefix=r".*", platsuffix="", with_ext=True):
def infer_arch_from_bits(os, bits, processor):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os is not actually used in this method. Also, docstring is missing.

@saschanaz
Copy link
Contributor Author

Thanks for the contribution!

Few minor comments. If you'd like to test a release of this (e.g., for mozregression-gui), let me know, I can trigger a full "dev" build.

Will that be different from local gui build?

@zzzeid
Copy link
Collaborator

zzzeid commented Sep 12, 2024

Thanks for the contribution!
Few minor comments. If you'd like to test a release of this (e.g., for mozregression-gui), let me know, I can trigger a full "dev" build.

Will that be different from local gui build?

It's more or less python gui/build.py bundle (under the controlled CI environment) and then some additional packaging related things. So slightly different flow than build.py run, but I suspect there isn't any difference functionally.

@saschanaz saschanaz closed this Sep 19, 2024
@saschanaz saschanaz reopened this Sep 19, 2024
@saschanaz
Copy link
Contributor Author

(Retriggering CI)

@zzzeid zzzeid merged commit a475127 into mozilla:main Oct 3, 2024
@saschanaz saschanaz deleted the bug1917418 branch October 4, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants