Skip to content

workflows: fix outdated/hardcoded requirements file (bug 1902706)#1734

Merged
zzzeid merged 1 commit intomainfrom
zeid/bug-1902706-update-hardcoded-requirements-file
Jun 14, 2024
Merged

workflows: fix outdated/hardcoded requirements file (bug 1902706)#1734
zzzeid merged 1 commit intomainfrom
zeid/bug-1902706-update-hardcoded-requirements-file

Conversation

@zzzeid
Copy link
Collaborator

@zzzeid zzzeid commented Jun 14, 2024

Another missed change to line up with the previous updates to the test workflow.

In the future, we should somehow consolidate the common aspects of these configurations into a central place or import them from elsewhere, since changes to deploy-gui.yml do not get tested as part of the usual CI, and only as part of deployments.

@zzzeid zzzeid requested a review from cgsheeh June 14, 2024 17:14
Copy link
Member

@cgsheeh cgsheeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have build and deploy as separate steps, and deploy depend on build? That would decrease the amount of code which only runs during releases.

@zzzeid
Copy link
Collaborator Author

zzzeid commented Jun 14, 2024

Is it possible to have build and deploy as separate steps, and deploy depend on build? That would decrease the amount of code which only runs during releases.

Yeah, there are a few different ways of getting this done, but most of them require a bit of a re-architecture of the workflows so that they are combined into a single workflow. Currently we have two workflows, one that "builds and tests" and one that "builds and deploys". Another thing we could do is always deploy a dev release before we deploy a full release, when there is a change to GA workflows.

@zzzeid zzzeid merged commit 2ee4c9d into main Jun 14, 2024
@zzzeid zzzeid deleted the zeid/bug-1902706-update-hardcoded-requirements-file branch June 14, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants