Bug 2003478 - New lint: Warn against event metrics on the metrics or baseline ping#823
Merged
Bug 2003478 - New lint: Warn against event metrics on the metrics or baseline ping#823
metrics or baseline ping#823Conversation
chutten
reviewed
Dec 8, 2025
Contributor
chutten
left a comment
chutten
left a comment
There was a problem hiding this comment.
What are your opinions about event metrics on the "deletion-request" ping? On the "health" ping?
Should this forbid event metrics on all non-"events" builtin pings?
badboy
force-pushed
the
push-mqoypkustuxn
branch
from
e3eec62 to
3a9a24c
Compare
chutten
approved these changes
Dec 8, 2025
badboy
force-pushed
the
push-mqoypkustuxn
branch
from
26f9290 to
69fed3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.