Skip to content

chore(python_server): support sending custom pings without events#817

Merged
akkomar merged 4 commits intomozilla:mainfrom
relud:relud-python-no-event
Nov 3, 2025
Merged

chore(python_server): support sending custom pings without events#817
akkomar merged 4 commits intomozilla:mainfrom
relud:relud-python-no-event

Conversation

@relud
Copy link
Contributor

@relud relud commented Oct 31, 2025

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@relud relud requested review from a team and akkomar as code owners October 31, 2025 21:30
@relud relud requested review from jeddai and removed request for a team October 31, 2025 21:30
Copy link
Collaborator

@akkomar akkomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although we wanted to steer apps towards using event metrics, pings-as-events does seem to make sense in some cases.

@akkomar akkomar merged commit dba14bf into mozilla:main Nov 3, 2025
8 checks passed
@relud relud deleted the relud-python-no-event branch November 3, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants