Add the commonjs_server option to the javascript_server outputter#726
Merged
akkomar merged 1 commit intomozilla:mainfrom Jul 15, 2024
Merged
Add the commonjs_server option to the javascript_server outputter#726akkomar merged 1 commit intomozilla:mainfrom
commonjs_server option to the javascript_server outputter#726akkomar merged 1 commit intomozilla:mainfrom
Conversation
Contributor
Author
|
@akkomar can you take a look? Thanks! |
akkomar
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately some nodejs services still need to use CommonJS. This patch adds an
-foption to generate JS in the CommonJS module format.Pull Request checklist
make testruns without emitting any warningsmake lintruns without emitting any errorsCHANGELOG.mdor an explanation of why it does not need one