Ensure description if risk_technical#1148
Merged
jaredlockhart merged 1 commit intomozilla:masterfrom Apr 5, 2019
robhudson:1082-fix
Merged
Ensure description if risk_technical#1148jaredlockhart merged 1 commit intomozilla:masterfrom robhudson:1082-fix
risk_technical#1148jaredlockhart merged 1 commit intomozilla:masterfrom
robhudson:1082-fix
Conversation
jaredlockhart
requested changes
Apr 4, 2019
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Thank you @robhudson looks good, just one change.
| class ExperimentRisksForm(ChangeLogMixin, forms.ModelForm): | ||
| RADIO_OPTIONS = ((False, "No"), (True, "Yes")) | ||
|
|
||
| def coerce_truthy(value): |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| help_text=Experiment.RISK_INTERNAL_ONLY_HELP_TEXT, | ||
| choices=RADIO_OPTIONS, | ||
| widget=RadioWidget, | ||
| coerce=coerce_truthy, |
Collaborator
There was a problem hiding this comment.
I think you can just say coerce=bool here?
Author
There was a problem hiding this comment.
The value getting passed to these is a string of either "True" or "False" which come from the RADIO_OPTIONS after going through a string conversion in Django-land. And bool("False") => True which isn't what we want.
jaredlockhart
approved these changes
Apr 5, 2019
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
@robhudson Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1082