Added support and documentation for Trusted Types #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not an expert on the trusted types directive, but the code looks good to me. Anyone else want to give a review for the docs and direction? @g-k ? |
g-k
approved these changes
Aug 12, 2020
| Types are used to prevent client-side or DOM-XSS_. Trusted Types rely on | ||
| the browser to enforce the policy that is provided to it. Currently, Trusted | ||
| Types are supported on Chrome 83 and Android Webview. Many browsers are in the | ||
| process of adding support. Check back for updated compatibility_. |
There was a problem hiding this comment.
nit: would be good to mention the polyfill too https://github.com/w3c/webappsec-trusted-types#polyfill
|
There are two trusted types PRs. This one and #158. This one has docs but that one was first. I appreciate all of the contributions but I'm not sure how best to proceed. |
|
CI is failing on #157 with a line length pep8 nit. I'm in favor of landing this one since CI is passing and it includes docs. |
|
I'll be looking into doing that today. |
|
Version 3.7 is now on PyPI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157