Va list binding compatibility by gerard-ryan-immersaview · Pull Request #970 · mozilla/cbindgen

gerard-ryan-immersaview · 2024-05-27T06:11:12Z

From what I can tell a va_list should be created by calling va_start and no documentation that I could find specifies the use of va_list as an argument explicitly.
Assuming this works, I imagine that some compilers happen to implement va_list and ... the same, but ... seems the be the specified way.

I haven't done any runtime testing of these changes, so if this is wrong I'd love to know why.

Sources:

Related: #968

Closes: #891

emilio · 2024-05-27T08:19:41Z

Tests are failing because:

Output failed to compile: Output { status: ExitStatus(unix_wait_status(256)), stdout: "", stderr: "/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:6:32: error: ISO C requires a named argument before ‘...’\n    6 | typedef int32_t (*VaListFnPtr)(...);\n      |                                ^~~\n/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:11:18: error: ISO C requires a named argument before ‘...’\n   11 |   int32_t (*fn1)(...);\n      |                  ^~~\n/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:22:22: error: ISO C requires a named argument before ‘...’\n   22 | int32_t va_list_test(...);\n      |                      ^~~\n/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:24:23: error: ISO C requires a named argument before ‘...’\n   24 | int32_t va_list_test2(...);\n      |                       ^~~\n/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:26:37: error: ISO C requires a named argument before ‘...’\n   26 | void va_list_fn_ptrs(int32_t (*fn1)(...),\n      |                                     ^~~\ncc1: note: unrecognized command-line option ‘-Wno-return-type-c-linkage’ may have been intended to silence earlier diagnostics\n" }

Let's just add a dummy char* or somesuch argument to the function types?

In general this looks good. Could you clean up the commit history to avoid having reverts and so on if you don't mind? Thanks.

emilio · 2024-05-27T08:20:52Z

Also, in the commit messages and PR title, please use compatibility rather than compatability? I think the later is a typo (but not an english speaker so icbw)

`va_list` -> `...` * https://en.cppreference.com/w/c/language/variadic * https://en.cppreference.com/w/cpp/language/variadic_arguments

gerard-ryan-immersaview · 2024-05-28T00:18:24Z

Tests are failing because:

Output failed to compile: Output { status: ExitStatus(unix_wait_status(256)), stdout: "", stderr: "/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:6:32: error: ISO C requires a named argument before ‘...’\n    6 | typedef int32_t (*VaListFnPtr)(...);\n      |                                ^~~\n/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:11:18: error: ISO C requires a named argument before ‘...’\n   11 |   int32_t (*fn1)(...);\n      |                  ^~~\n/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:22:22: error: ISO C requires a named argument before ‘...’\n   22 | int32_t va_list_test(...);\n      |                      ^~~\n/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:24:23: error: ISO C requires a named argument before ‘...’\n   24 | int32_t va_list_test2(...);\n      |                       ^~~\n/home/runner/work/cbindgen/cbindgen/target/package/cbindgen-0.26.0/tests/expectations/va_list.compat.c:26:37: error: ISO C requires a named argument before ‘...’\n   26 | void va_list_fn_ptrs(int32_t (*fn1)(...),\n      |                                     ^~~\ncc1: note: unrecognized command-line option ‘-Wno-return-type-c-linkage’ may have been intended to silence earlier diagnostics\n" }

Let's just add a dummy char* or somesuch argument to the function types?

Oh, I was wondering why this was compiling before, I just assumed it was using c23 like I was, but regardless, I fixed this now.

In general this looks good. Could you clean up the commit history to avoid having reverts and so on if you don't mind? Thanks.

I squashed all the commits except the code move commit because it makes the diffs nicer.

kanru · 2024-05-28T22:47:03Z

tests/expectations/va_list.c

+int32_t va_list_test2(int32_t count, ...);
+
+void va_list_fn_ptrs(int32_t (*fn1)(int32_t count, ...),
+                     int32_t (*fn2)(int32_t count),


It looks like when used in function pointer the dotdotdot version does not emit the va args dots in the C version. Is this intended?

Created #971

I added this test to highlight the existing limitation.
I had attempted to address it with #969 but there appears to have been some miscommunication.

Updates the requirements on [cbindgen](https://github.com/mozilla/cbindgen) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/mozilla/cbindgen/blob/master/CHANGES">cbindgen's changelog</a>.</em></p> <blockquote> <h1>0.27.0</h1> <pre><code> * Revert: The `Config` struct now has a private member. * Allow users to specify a crate version for bindings generation ([#901](mozilla/cbindgen#901)). * Update MSRV to 1.74 ([#912](mozilla/cbindgen#912), [#987](mozilla/cbindgen#987)). * Support #[deprecated] on enum variants ([#933](mozilla/cbindgen#933)). * Support integrating the package_version information in a header file comment ([#939](mozilla/cbindgen#939)). * Add a language backend ([#942](mozilla/cbindgen#942)). * Support generics with defaulted args ([#959](mozilla/cbindgen#959)). * Add `VaList` compatibility ([#970](mozilla/cbindgen#970)). </code></pre> <h1>0.26.0</h1> <pre><code> * Fix swapping of `>>=` and `<<=` in constants. * Add support for #[deprecated] ([#860](mozilla/cbindgen#860)). * Built-in support for bitflags 2.0. * Support for "C-unwind" ABI. * Generate bindings for non-public extern items if they are #[no_mangle]. </code></pre> <h2>0.25.0</h2> <pre><code> * Re-release of yanked 0.24.6 as a major release * Update MSRV to 1.57 * Support variadic arguments (`...`) ([#805](mozilla/cbindgen#805)) * Add --depfile option ([#820](mozilla/cbindgen#820)) * Breaking changes: The `Config` struct now has a private member. </code></pre> <h2>0.24.6 (YANKED: depfile option was breaking, see <a href="https://redirect.github.com/mozilla/cbindgen/issues/841">#841</a>)</h2> <pre><code> * Update MSRV to 1.57 * Support variadic arguments (`...`) ([#805](mozilla/cbindgen#805)) * Add --depfile option ([#820](mozilla/cbindgen#820)) </code></pre> <h2>0.24.5</h2> <pre><code> * Don't enforce tempfile version. </code></pre> <h2>0.24.4</h2> <pre><code> * Move expand infinite recursion fix ([#799](mozilla/cbindgen#799)) * Add with_cpp_compat to the builder ([#796](mozilla/cbindgen#796)) * Handle never type in return position consistently ([#780](mozilla/cbindgen#780)) * Fix warnings ([#816](mozilla/cbindgen#816), [#819](mozilla/cbindgen#819)) * Updated documentation ([#788](mozilla/cbindgen#788), [#791](mozilla/cbindgen#791), [#792](mozilla/cbindgen#792), [#810](mozilla/cbindgen#810), [#823](mozilla/cbindgen#823)) </code></pre> <h2>0.24.3</h2> <pre><code> * Make struct expressions correctly generated through typedefs ([#768](mozilla/cbindgen#768)). </code></pre> <h2>0.24.2</h2>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mozilla/cbindgen/commit/58c6156b0d91e82abb03c26187b8d18fa4345ce0"><code>58c6156</code></a> Bump MSRV again for clap.</li> <li><a href="https://github.com/mozilla/cbindgen/commit/103a8de0ac1ac311d54843acdfc10ee8c203a3ba"><code>103a8de</code></a> Cargo update and version bump.</li> <li><a href="https://github.com/mozilla/cbindgen/commit/67cb560430cf91fecdd402cd1239d0a51baff634"><code>67cb560</code></a> Update CHANGES since v0.26.0</li> <li><a href="https://github.com/mozilla/cbindgen/commit/316298182ebf508240c95ddf9943556b2fb546e1"><code>3162981</code></a> Output condition for globals.</li> <li><a href="https://github.com/mozilla/cbindgen/commit/e469e44c0027f4ca039a4556f6062c0ba343a5b4"><code>e469e44</code></a> Add missing parens to log message</li> <li><a href="https://github.com/mozilla/cbindgen/commit/3cbb637bbf16c7378ce4d6cb4b73e5d2d2bd33fa"><code>3cbb637</code></a> Update cython expectations from the previous patch.</li> <li><a href="https://github.com/mozilla/cbindgen/commit/785e066e03b0e22a32c31e9adab78a18f6ce195b"><code>785e066</code></a> Fix variadic arguments when used in function pointer</li> <li><a href="https://github.com/mozilla/cbindgen/commit/aa8ea654e156fd1b8e5b1b755c7b43fe4ea81331"><code>aa8ea65</code></a> deps: Update syn to 2.0</li> <li><a href="https://github.com/mozilla/cbindgen/commit/9f632843b8b9dacbdc7a153868a4a9546e196e2e"><code>9f63284</code></a> Generalize Item to expose documentation and generic params</li> <li><a href="https://github.com/mozilla/cbindgen/commit/1dda6162e53df57cb1769e9a6f942f6de839f50b"><code>1dda616</code></a> Used documented method of specifying variadic arguments</li> <li>Additional commits viewable in <a href="https://github.com/mozilla/cbindgen/compare/0.26.0...v0.27.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Updates the requirements on [cbindgen](https://github.com/mozilla/cbindgen) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mozilla/cbindgen/releases">cbindgen's releases</a>.</em></p> <blockquote> <h1>0.28.0</h1> <ul> <li>Parse unsafe attributes in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1020">mozilla/cbindgen#1020</a></li> <li>Fix local override of enum prefix-with-name by jsgf in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1006">mozilla/cbindgen#1006</a></li> <li>Add rename-all=prefix in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1021">mozilla/cbindgen#1021</a></li> <li>ir: add support for UnsafeCell and SyncUnsafeCell by alekitto in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1003">mozilla/cbindgen#1003</a></li> <li>Implement mangling for arrays in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1022">mozilla/cbindgen#1022</a></li> <li>Fix: Ignore <code>CARGO_BUILD_TARGET</code> in tests by bryango in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1010">mozilla/cbindgen#1010</a></li> <li>Newline for each field for constexpr field constants by youknowone in <a href="https://redirect.github.com/mozilla/cbindgen/pull/988">mozilla/cbindgen#988</a></li> <li>Fix clippy warnings by youknowone in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1026">mozilla/cbindgen#1026</a></li> <li>Add aarch64/arm64 to CI by NickeZ in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1036">mozilla/cbindgen#1036</a></li> <li>Add <code>unstable_ir</code> feature flag that makes the ir pub by heesooy in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1011">mozilla/cbindgen#1011</a></li> <li>Support generated a symbols file by TheElectronWill in <a href="https://redirect.github.com/mozilla/cbindgen/pull/916">mozilla/cbindgen#916</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/mozilla/cbindgen/blob/master/CHANGES">cbindgen's changelog</a>.</em></p> <blockquote> <h1>0.28.0</h1> <pre><code> * Parse unsafe attributes in mozilla/cbindgen#1020 * Fix local override of enum prefix-with-name by jsgf in mozilla/cbindgen#1006 * Add rename-all=prefix in mozilla/cbindgen#1021 * ir: add support for UnsafeCell and SyncUnsafeCell by alekitto in mozilla/cbindgen#1003 * Implement mangling for arrays in mozilla/cbindgen#1022 * Fix: Ignore `CARGO_BUILD_TARGET` in tests by bryango in mozilla/cbindgen#1010 * Newline for each field for constexpr field constants by youknowone in mozilla/cbindgen#988 * Fix clippy warnings by youknowone in mozilla/cbindgen#1026 * Add aarch64/arm64 to CI by NickeZ in mozilla/cbindgen#1036 * Add `unstable_ir` feature flag that makes the ir pub by heesooy in mozilla/cbindgen#1011 * Support generated a symbols file by TheElectronWill in mozilla/cbindgen#916 </code></pre> <h1>0.27.0</h1> <pre><code> * Revert: The `Config` struct now has a private member. * Allow users to specify a crate version for bindings generation ([#901](mozilla/cbindgen#901)). * Update MSRV to 1.74 ([#912](mozilla/cbindgen#912), [#987](mozilla/cbindgen#987)). * Support #[deprecated] on enum variants ([#933](mozilla/cbindgen#933)). * Support integrating the package_version information in a header file comment ([#939](mozilla/cbindgen#939)). * Add a language backend ([#942](mozilla/cbindgen#942)). * Support generics with defaulted args ([#959](mozilla/cbindgen#959)). * Add `VaList` compatibility ([#970](mozilla/cbindgen#970)). </code></pre> <h1>0.26.0</h1> <pre><code> * Fix swapping of `>>=` and `<<=` in constants. * Add support for #[deprecated] ([#860](mozilla/cbindgen#860)). * Built-in support for bitflags 2.0. * Support for "C-unwind" ABI. * Generate bindings for non-public extern items if they are #[no_mangle]. </code></pre> <h2>0.25.0</h2> <pre><code> * Re-release of yanked 0.24.6 as a major release * Update MSRV to 1.57 * Support variadic arguments (`...`) ([#805](mozilla/cbindgen#805)) * Add --depfile option ([#820](mozilla/cbindgen#820)) * Breaking changes: The `Config` struct now has a private member. </code></pre> <h2>0.24.6 (YANKED: depfile option was breaking, see <a href="https://redirect.github.com/mozilla/cbindgen/issues/841">#841</a>)</h2> <pre><code> * Update MSRV to 1.57 * Support variadic arguments (`...`) ([#805](mozilla/cbindgen#805)) * Add --depfile option ([#820](mozilla/cbindgen#820)) </code></pre> <h2>0.24.5</h2> <pre><code> * Don't enforce tempfile version. </code></pre>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mozilla/cbindgen/commit/bd78bbe59b10eda6ef1255e4acda95c56c6d0279"><code>bd78bbe</code></a> Release 0.28.0</li> <li><a href="https://github.com/mozilla/cbindgen/commit/8ca9c4c20ff9ca59a3c4f0b068ce3a7da2e02e9e"><code>8ca9c4c</code></a> tests: Fix symbol file and tests.</li> <li><a href="https://github.com/mozilla/cbindgen/commit/152f91dee070b1ebc28505b908066c9c418ed50e"><code>152f91d</code></a> Appease clippy.</li> <li><a href="https://github.com/mozilla/cbindgen/commit/70b9d7a98084c39dbb5d0f0115d4e5917e2c8f6c"><code>70b9d7a</code></a> tests: Run rustfmt.</li> <li><a href="https://github.com/mozilla/cbindgen/commit/87afbf9e01ae8d9190638d4b347676ff7e282d4f"><code>87afbf9</code></a> Add a way to generate a list of symbols for dynamic linkage, resolves <a href="https://redirect.github.com/mozilla/cbindgen/issues/907">#907</a></li> <li><a href="https://github.com/mozilla/cbindgen/commit/80c50c643a453bd396331b4a8eb17a47f7c6c6b1"><code>80c50c6</code></a> Add <code>unstable_ir</code> feature flag that makes the ir pub</li> <li><a href="https://github.com/mozilla/cbindgen/commit/e82815e99a96d9510316855583d4fef094396f10"><code>e82815e</code></a> Refactor arm64 build to matrix strategy</li> <li><a href="https://github.com/mozilla/cbindgen/commit/a5e1443a4503826036bfaa6a349fc0b05d188d61"><code>a5e1443</code></a> Add aarch64/arm64 to CI</li> <li><a href="https://github.com/mozilla/cbindgen/commit/b9b8f8878ac272935193c449066b88c0cb94ced2"><code>b9b8f88</code></a> Fix clippy warnings</li> <li><a href="https://github.com/mozilla/cbindgen/commit/89a9faa97cc267e90fc95a1cc6177a001aed5b51"><code>89a9faa</code></a> newlines for constexpr</li> <li>Additional commits viewable in <a href="https://github.com/mozilla/cbindgen/compare/v0.27.0...0.28.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Updates the requirements on [cbindgen](https://github.com/mozilla/cbindgen) to permit the latest version. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mozilla/cbindgen/releases">cbindgen's releases</a>.</em></p> <blockquote> <h1>0.29.0</h1> <ul> <li>Support no-export annotation for statics and functions.</li> <li>Fixed conditional fields of constexpr literal structs</li> <li>Add rename rule for generated associated constant</li> <li>Upgrade heck to 0.5</li> <li>Add support for an optional nullable attribute</li> <li>docs.md: Fix deprecated_with_note and deprecated_variant_with_note being spelled as 'notes'</li> <li>Fix generic with "void" default</li> <li>Fixed error generation of structures using the keyword as inside arrays</li> <li>Added test for unsafe(no_mangle) attribute</li> <li>Fixed handling of trait methods containing the unsafe attribute</li> <li>Rename -Zparse-only</li> </ul> <h1>0.28.0</h1> <ul> <li>Parse unsafe attributes in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1020">mozilla/cbindgen#1020</a></li> <li>Fix local override of enum prefix-with-name by jsgf in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1006">mozilla/cbindgen#1006</a></li> <li>Add rename-all=prefix in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1021">mozilla/cbindgen#1021</a></li> <li>ir: add support for UnsafeCell and SyncUnsafeCell by alekitto in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1003">mozilla/cbindgen#1003</a></li> <li>Implement mangling for arrays in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1022">mozilla/cbindgen#1022</a></li> <li>Fix: Ignore <code>CARGO_BUILD_TARGET</code> in tests by bryango in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1010">mozilla/cbindgen#1010</a></li> <li>Newline for each field for constexpr field constants by youknowone in <a href="https://redirect.github.com/mozilla/cbindgen/pull/988">mozilla/cbindgen#988</a></li> <li>Fix clippy warnings by youknowone in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1026">mozilla/cbindgen#1026</a></li> <li>Add aarch64/arm64 to CI by NickeZ in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1036">mozilla/cbindgen#1036</a></li> <li>Add <code>unstable_ir</code> feature flag that makes the ir pub by heesooy in <a href="https://redirect.github.com/mozilla/cbindgen/pull/1011">mozilla/cbindgen#1011</a></li> <li>Support generated a symbols file by TheElectronWill in <a href="https://redirect.github.com/mozilla/cbindgen/pull/916">mozilla/cbindgen#916</a></li> </ul> <h1>0.27.0</h1> <ul> <li>Revert: The <code>Config</code> struct now has a private member.</li> <li>Allow users to specify a crate version for bindings generation (<a href="https://redirect.github.com/mozilla/cbindgen/issues/901">#901</a>).</li> <li>Update MSRV to 1.74 (<a href="https://redirect.github.com/mozilla/cbindgen/issues/912">#912</a>, <a href="https://redirect.github.com/mozilla/cbindgen/issues/987">#987</a>).</li> <li>Support #[deprecated] on enum variants (<a href="https://redirect.github.com/mozilla/cbindgen/issues/933">#933</a>).</li> <li>Support integrating the package_version information in a header file comment (<a href="https://redirect.github.com/mozilla/cbindgen/issues/939">#939</a>).</li> <li>Add a language backend (<a href="https://redirect.github.com/mozilla/cbindgen/issues/942">#942</a>).</li> <li>Support generics with defaulted args (<a href="https://redirect.github.com/mozilla/cbindgen/issues/959">#959</a>).</li> <li>Add <code>VaList</code> compatibility (<a href="https://redirect.github.com/mozilla/cbindgen/issues/970">#970</a>).</li> </ul> <h1>0.26.0</h1> <ul> <li>Fix swapping of <code>>>=</code> and <code><<=</code> in constants.</li> <li>Add support for #[deprecated] (<a href="https://redirect.github.com/mozilla/cbindgen/issues/860">#860</a>).</li> <li>Built-in support for bitflags 2.0.</li> <li>Support for "C-unwind" ABI.</li> <li>Generate bindings for non-public extern items if they are #[no_mangle].</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/mozilla/cbindgen/blob/master/CHANGES">cbindgen's changelog</a>.</em></p> <blockquote> <h1>0.29.0</h1> <pre><code> * Support no-export annotation for statics and functions. * Fixed conditional fields of constexpr literal structs * Add rename rule for generated associated constant * Upgrade heck to 0.5 * Add support for an optional nullable attribute * docs.md: Fix deprecated_with_note and deprecated_variant_with_note being spelled as 'notes' * Fix generic with "void" default * Fixed error generation of structures using the keyword as inside arrays * Added test for unsafe(no_mangle) attribute * Fixed handling of trait methods containing the unsafe attribute * Rename -Zparse-only </code></pre> <h1>0.28.0</h1> <pre><code> * Parse unsafe attributes in mozilla/cbindgen#1020 * Fix local override of enum prefix-with-name by jsgf in mozilla/cbindgen#1006 * Add rename-all=prefix in mozilla/cbindgen#1021 * ir: add support for UnsafeCell and SyncUnsafeCell by alekitto in mozilla/cbindgen#1003 * Implement mangling for arrays in mozilla/cbindgen#1022 * Fix: Ignore `CARGO_BUILD_TARGET` in tests by bryango in mozilla/cbindgen#1010 * Newline for each field for constexpr field constants by youknowone in mozilla/cbindgen#988 * Fix clippy warnings by youknowone in mozilla/cbindgen#1026 * Add aarch64/arm64 to CI by NickeZ in mozilla/cbindgen#1036 * Add `unstable_ir` feature flag that makes the ir pub by heesooy in mozilla/cbindgen#1011 * Support generated a symbols file by TheElectronWill in mozilla/cbindgen#916 </code></pre> <h1>0.27.0</h1> <pre><code> * Revert: The `Config` struct now has a private member. * Allow users to specify a crate version for bindings generation ([#901](mozilla/cbindgen#901)). * Update MSRV to 1.74 ([#912](mozilla/cbindgen#912), [#987](mozilla/cbindgen#987)). * Support #[deprecated] on enum variants ([#933](mozilla/cbindgen#933)). * Support integrating the package_version information in a header file comment ([#939](mozilla/cbindgen#939)). * Add a language backend ([#942](mozilla/cbindgen#942)). * Support generics with defaulted args ([#959](mozilla/cbindgen#959)). * Add `VaList` compatibility ([#970](mozilla/cbindgen#970)). </code></pre> <h1>0.26.0</h1> <pre><code> * Fix swapping of `>>=` and `<<=` in constants. * Add support for #[deprecated] ([#860](mozilla/cbindgen#860)). * Built-in support for bitflags 2.0. * Support for "C-unwind" ABI. * Generate bindings for non-public extern items if they are #[no_mangle]. </code></pre> <h2>0.25.0</h2> <pre><code> * Re-release of yanked 0.24.6 as a major release </code></pre>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mozilla/cbindgen/commit/802154245edebe6bd031e473737da4c2fbdea8a3"><code>8021542</code></a> Release 0.29.0</li> <li><a href="https://github.com/mozilla/cbindgen/commit/f3a0ecd2a9242e7452acba475c6277e5c5f94079"><code>f3a0ecd</code></a> Support no-export annotation for statics and functions.</li> <li><a href="https://github.com/mozilla/cbindgen/commit/14fa2d0669fb80adb3e5a45915af73dc6e9c64c7"><code>14fa2d0</code></a> conditional fields of constexpr literal structs</li> <li><a href="https://github.com/mozilla/cbindgen/commit/021f3f3a422f2fe4a13db644277515fac5af0c16"><code>021f3f3</code></a> Add LiteralStructField</li> <li><a href="https://github.com/mozilla/cbindgen/commit/4b2396dabf630e3372089a68cdbdb73249a745ed"><code>4b2396d</code></a> Github action: Add aarch64 to deploy</li> <li><a href="https://github.com/mozilla/cbindgen/commit/2320ac4296b91257f0d3d502b28f5e319e006a2b"><code>2320ac4</code></a> Add rename rule for generated associated constant</li> <li><a href="https://github.com/mozilla/cbindgen/commit/5ac9dc046b8ebd06ae0826d92f4c3d8781f263f3"><code>5ac9dc0</code></a> Upgrade heck to 0.5</li> <li><a href="https://github.com/mozilla/cbindgen/commit/9f9da30c60a74abf843c41a56a6ec9fb3328fbf7"><code>9f9da30</code></a> Add support for an optional nullable attribute</li> <li><a href="https://github.com/mozilla/cbindgen/commit/36b9f0df42a7c686b897aef29b19fefd2d9950df"><code>36b9f0d</code></a> docs.md: Fix deprecated_with_note and deprecated_variant_with_note being spel...</li> <li><a href="https://github.com/mozilla/cbindgen/commit/0328601dc1a827d761913e1e08ccb3295c5b0c8a"><code>0328601</code></a> Fix generic with "void" default</li> <li>Additional commits viewable in <a href="https://github.com/mozilla/cbindgen/compare/0.28.0...0.29.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

v0.27.0 * Revert: The `Config` struct now has a private member. * Allow users to specify a crate version for bindings generation (mozilla#901). * Update MSRV to 1.74 (mozilla#912, mozilla#987). * Support #[deprecated] on enum variants (mozilla#933). * Support integrating the package_version information in a header file comment (mozilla#939). * Add a language backend (mozilla#942). * Support generics with defaulted args (mozilla#959). * Add `VaList` compatibility (mozilla#970). # Conflicts: # src/bindgen/bindings.rs # src/bindgen/cdecl.rs # src/bindgen/config.rs # src/bindgen/ir/constant.rs # src/bindgen/ir/documentation.rs # src/bindgen/ir/enumeration.rs # src/bindgen/ir/function.rs # src/bindgen/ir/opaque.rs # src/bindgen/ir/structure.rs # src/bindgen/ir/typedef.rs # src/bindgen/ir/union.rs # src/main.rs

gerard-ryan-immersaview changed the title ~~Va list binding compatability~~ Va list binding compatibility May 27, 2024

gerard-ryan-immersaview force-pushed the va_list_output_compatability branch from b313dbd to d1ba116 Compare May 27, 2024 23:56

gerard-ryan-immersaview added 3 commits May 28, 2024 10:03

Improved test coverage of va_list

85e1e4e

Parse function argument type first so it can be used to determine name

756c009

gerard-ryan-immersaview force-pushed the va_list_output_compatability branch from d1ba116 to bf5817f Compare May 28, 2024 00:07

gerard-ryan-immersaview mentioned this pull request May 28, 2024

Improved test coverage of va_list #968

Closed

emilio approved these changes May 28, 2024

View reviewed changes

emilio added this pull request to the merge queue May 28, 2024

Merged via the queue into mozilla:master with commit 1dda616 May 28, 2024

This was referenced May 28, 2024

Va list fn pointer typedef edge case fix #969

Closed

deps: Update syn to 2.0 #961

Closed

kanru reviewed May 28, 2024

View reviewed changes

gerard-ryan-immersaview deleted the va_list_output_compatability branch May 29, 2024 00:49

emilio mentioned this pull request Aug 10, 2024

Support converting Rust <name>: ... to C ... (varargs) #894

Closed

BrewTestBot mentioned this pull request Jan 15, 2025

cbindgen 0.27.0 Homebrew/homebrew-core#204326

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Va list binding compatibility#970

Va list binding compatibility#970
emilio merged 3 commits intomozilla:masterfrom
gerard-ryan-immersaview:va_list_output_compatability

gerard-ryan-immersaview commented May 27, 2024

Uh oh!

emilio commented May 27, 2024

Uh oh!

emilio commented May 27, 2024

Uh oh!

gerard-ryan-immersaview commented May 28, 2024

Uh oh!

kanru May 28, 2024

Uh oh!

kanru May 28, 2024

Uh oh!

gerard-ryan-immersaview May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gerard-ryan-immersaview commented May 27, 2024

Uh oh!

emilio commented May 27, 2024

Uh oh!

emilio commented May 27, 2024

Uh oh!

gerard-ryan-immersaview commented May 28, 2024

Uh oh!

kanru May 28, 2024

Choose a reason for hiding this comment

Uh oh!

kanru May 28, 2024

Choose a reason for hiding this comment

Uh oh!

gerard-ryan-immersaview May 29, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants