Fix ..Default::default() for struct Config#911
Merged
emilio merged 1 commit intomozilla:masterfrom Feb 6, 2024
Merged
Conversation
Previously the `depfile` option added a new private member to the `Config` struct - a breaking change which many users complained about. Making the field public, but hiding it from the documentation and excluding it from `serde` reverts the breakage, while keeping the depfile functionality.
Contributor
Author
|
@emilio Any chance you could find some time to review this patch? |
emilio
approved these changes
Feb 6, 2024
Collaborator
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
Thanks! Yeah, thanks for the ping, and sorry, I haven't been able to dedicate a lot of time to cbindgen recently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
depfileoption added a new private member to theConfigstruct - a breaking change which many users complained about. Making the field public, but hiding it from the documentation and excluding it fromserdereverts the breakage, while keeping the depfile functionality.I also considered adding an
InternalConfigstruct, but this would require breaking changes to at leastConfig::from_file()andConfig::from_root_or_default(), which is a lot more invasive than my PR.Closes #908