Support the "C-unwind" ABI#864
Closed
taeruh wants to merge 3 commits intomozilla:masterfrom
taeruh:support_unwind_abi
Closed
Support the "C-unwind" ABI#864taeruh wants to merge 3 commits intomozilla:masterfrom taeruh:support_unwind_abi
taeruh wants to merge 3 commits intomozilla:masterfrom
taeruh:support_unwind_abi
Conversation
The proc-macro2 crate with version 1.0.58 did not compile with "rustc 1.73.0-nightly (d12c6e947 2023-08-01)".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "C-unwind" ABI string has been stabilized in Rust 1.71(cf. rust-lang/rust#74990 (comment)). This PR enables cbindgen to recognize these functions as C-compatible functions.
Also, I had to update the patch version of proc-macro2 in the lock file, because the nightly build failed. Maybe this should be done in Cargo.toml too?