Skip to content

Fixed some issues when setting up new environment.#859

Merged
emilio merged 3 commits intomozilla:masterfrom
sevenc-nanashi:fix/new-environment-errors
Aug 25, 2023
Merged

Fixed some issues when setting up new environment.#859
emilio merged 3 commits intomozilla:masterfrom
sevenc-nanashi:fix/new-environment-errors

Conversation

@sevenc-nanashi
Copy link
Copy Markdown
Contributor

@sevenc-nanashi sevenc-nanashi commented Jul 22, 2023

(My mother language is not English, so I may say some inappropriate things.)
I tried to contribute project, but there were some errors. I fixed them.

Cython 3 detail

As cython 3 prints this warning, the snapshot doesn't match.

Error compiling Cython file:
------------------------------------------------------------
...
from libc.stdint cimport int8_t, int16_t,

int32_t, int64_t, intptr_t
^
------------------------------------------------------------

tests/expectations/workspace.tag.pyx:1:0: Dotted filenames ('workspace.tag.pyx') are deprecated. Please use the normal Python package directory layout.

@sevenc-nanashi sevenc-nanashi changed the title Some fix for new contributers. Fixed some issues when setting up the environment. Jul 22, 2023
@sevenc-nanashi sevenc-nanashi changed the title Fixed some issues when setting up the environment. Fixed some issues when setting up new environment. Jul 22, 2023
@jschwe
Copy link
Copy Markdown
Contributor

jschwe commented Jul 24, 2023

This project requires nightly rust (as test uses -Z). Added rust-toolchain.toml.

Some features / tests require nightly (expanding macros), but in general cbindgen runs fine on stable Rust 1.57 and newer

@sevenc-nanashi
Copy link
Copy Markdown
Contributor Author

Oh, my writing was bad. Fixed

@emilio emilio merged commit 667de09 into mozilla:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants