Fix swapping of >>= and <<= in constants#850
Closed
jschwe wants to merge 2 commits intomozilla:masterfrom
Closed
Conversation
mversic
approved these changes
Jul 17, 2023
emilio
approved these changes
Aug 25, 2023
| syn::BinOp::ShlEq(..) => ">>=", | ||
| syn::BinOp::ShrEq(..) => "<<=", | ||
| syn::BinOp::ShlEq(..) => "<<=", | ||
| syn::BinOp::ShrEq(..) => ">>=", |
Collaborator
There was a problem hiding this comment.
Looks good but would there be any chance to add a test for this?
Contributor
Author
There was a problem hiding this comment.
Upon looking at this again, I don't think it is possible to use <<= in constants at all, since the left hand side must be a variable. So probably these cases could also be an unreachable!() instead.
Collaborator
There was a problem hiding this comment.
Let's merge this since it's trivial, it's not a big deal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShlEqis shift left equals, i.e.<<=, so it was previously mapped the wrong way.