bindgen: enable "void prototype" while writing struct field#473
Merged
emilio merged 2 commits intomozilla:masterfrom Feb 17, 2020
Merged
bindgen: enable "void prototype" while writing struct field#473emilio merged 2 commits intomozilla:masterfrom
emilio merged 2 commits intomozilla:masterfrom
Conversation
This fixs typedef's signature in C as well because a typedef statement is constructed like, "typedef " + field_like_string.
emilio
requested changes
Feb 15, 2020
Collaborator
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
Contributor
Author
|
Looks like CI failed with some irrelevant issues (it didn't even start running tests), could we rerun it again or if there's anything I can do? |
Collaborator
|
I cleared caches (builds just time out when they get too big) and restarted the build. Thanks! |
emilio
approved these changes
Feb 17, 2020
Collaborator
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
LGTM. I think we should probably just pass config down, but no big deal and can be a followup anyway.
Collaborator
|
Thanks a lot for the fix! |
Contributor
Author
|
It's my pleasure as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #470
This
voidin some C++ files should be fine according to standard (ref)Let's me know if there's anything I can improve :)