Skip to content

Add a test for generic pointer parameter#453

Closed
kvark wants to merge 1 commit intomozilla:masterfrom
kvark:generic-pointer
Closed

Add a test for generic pointer parameter#453
kvark wants to merge 1 commit intomozilla:masterfrom
kvark:generic-pointer

Conversation

@kvark
Copy link
Copy Markdown
Contributor

@kvark kvark commented Jan 12, 2020

The test is a reduced version of gfx-rs/wgpu#440 (comment) . It currently fails. cc @emilio

@emilio
Copy link
Copy Markdown
Collaborator

emilio commented Jan 12, 2020

Ah, so that panic is basically an unimplemented!. Someone needs to come up with a mangling scheme for that, but it shouldn't be too hard.

@TheKK
Copy link
Copy Markdown
Contributor

TheKK commented Mar 3, 2020

Is there any name mangling guideline we can follow?
For this PR we need to implement mangling for Type::ConstPtr(Box<Type>) and it's a little tricky to handle nested type if we want to present them in flat type name.

emilio added a commit to emilio/cbindgen that referenced this pull request Apr 10, 2020
Ugly, but better than crashing.

Closes mozilla#506.
Closes mozilla#453.
emilio added a commit to emilio/cbindgen that referenced this pull request Apr 10, 2020
Ugly, but better than crashing.

Closes mozilla#506.
Closes mozilla#453.
@emilio emilio mentioned this pull request Apr 10, 2020
@emilio emilio closed this in #508 Apr 10, 2020
emilio added a commit that referenced this pull request Apr 10, 2020
Ugly, but better than crashing.

Closes #506.
Closes #453.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants