Fix missing C header for char32_t#414
Merged
emilio merged 2 commits intomozilla:masterfrom Dec 2, 2019
adrianwong:char32_t
Merged
Fix missing C header for char32_t#414emilio merged 2 commits intomozilla:masterfrom adrianwong:char32_t
emilio merged 2 commits intomozilla:masterfrom
adrianwong:char32_t
Conversation
Contributor
Author
|
Build's failed due to timeout. |
Collaborator
|
Yeah, the travis failure was a caching issue, I restarted the build to hopefully address it. |
Collaborator
|
So, we compile all our C/C++ files on CI. Why was this not an issue? Does gcc somehow end up pulling in |
Contributor
Author
|
Turns out it wasn't an issue because there was no existing C test for (The I've pushed a new commit that adds a basic |
emilio
approved these changes
Dec 2, 2019
Collaborator
emilio
left a comment
emilio
left a comment
There was a problem hiding this comment.
That makes sense. Thanks for the test and for bearing with me! :)
Contributor
Author
|
No, thank you for the prompts! They were the right questions to ask. If you could make a new release for this (when you can spare the time!), that would be fantastic. |
emilio
added a commit
to emilio/cbindgen
that referenced
this pull request
Dec 2, 2019
* Improved error message for missing config file. mozilla#422 * Add missing header for char32_t. mozilla#414
Collaborator
|
Just published v0.10.1 with this change and #422. Thanks again! |
Contributor
Author
|
Legend! |
bors bot
added a commit
to jjs-dev/jjs
that referenced
this pull request
Dec 12, 2019
134: Bump cbindgen from 0.10.0 to 0.11.1 r=MikailBag a=dependabot-preview[bot] Bumps [cbindgen](https://github.com/eqrion/cbindgen) from 0.10.0 to 0.11.1. <details> <summary>Changelog</summary> *Sourced from [cbindgen's changelog](https://github.com/eqrion/cbindgen/blob/master/CHANGES).* > ## 0.11.1 > > * More binary operators and expressions are supported. [mozilla/cbindgen#425](https://github-redirect.dependabot.com/eqrion/cbindgen/pull/425) > * More built-in bitflags operators. [mozilla/cbindgen#426](https://github-redirect.dependabot.com/eqrion/cbindgen/pull/426) > > ## 0.11.0 > > * Made rust char map to uint32_t. [mozilla/cbindgen#424](https://github-redirect.dependabot.com/eqrion/cbindgen/pull/424) > > ## 0.10.1 > > * Improved error message for missing config file. [mozilla/cbindgen#422](https://github-redirect.dependabot.com/eqrion/cbindgen/pull/422) > * Add missing header for char32_t. [mozilla/cbindgen#414](https://github-redirect.dependabot.com/eqrion/cbindgen/pull/414) </details> <details> <summary>Commits</summary> - [`e050442`](mozilla/cbindgen@e050442) Add CHANGES entry for v0.11.1 - [`c8f94b5`](mozilla/cbindgen@c8f94b5) v0.11.1 - [`230042b`](mozilla/cbindgen@230042b) Implement more operators for bitflags. - [`e0fe4e4`](mozilla/cbindgen@e0fe4e4) Add tests for expressions like `(0 << SHIFT) | BOOL` - [`df347d9`](mozilla/cbindgen@df347d9) Handle parenthesized literals like `(1 << 5)` - [`9a1f4b7`](mozilla/cbindgen@9a1f4b7) Handle identifiers in const declarations like SHIFT in `1 << SHIFT` - [`b1a92e2`](mozilla/cbindgen@b1a92e2) Handle all binary operations and make pattern match exhaustive - [`d996e7c`](mozilla/cbindgen@d996e7c) Refactor pattern match for Syn::Expr::Lit - [`9b7bb8f`](mozilla/cbindgen@9b7bb8f) Update docs to account for the latest char => char32_t change. - [`0355c3c`](mozilla/cbindgen@0355c3c) v0.11.0 - Additional commits viewable in [compare view](mozilla/cbindgen@v0.10.0...v0.11.1) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=cbindgen&package-manager=cargo&previous-version=0.10.0&new-version=0.11.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 135: Bump nix from 0.15.0 to 0.16.0 r=MikailBag a=dependabot-preview[bot] Bumps [nix](https://github.com/nix-rust/nix) from 0.15.0 to 0.16.0. <details> <summary>Changelog</summary> *Sourced from [nix's changelog](https://github.com/nix-rust/nix/blob/master/CHANGELOG.md).* > ## [0.16.0] - 1 December 2019 > ### Added > - Added `ptrace::seize()`: similar to `attach()` on Linux > but with better-defined semantics. > (#[1154](https://github-redirect.dependabot.com/nix-rust/nix/pull/1154)) > > - Added `Signal::as_str()`: returns signal name as `&'static str` > (#[1138](https://github-redirect.dependabot.com/nix-rust/nix/pull/1138)) > > - Added `posix_fallocate`. > ([#1105](https://github-redirect.dependabot.com/nix-rust/nix/pull/1105)) > > - Implemented `Default` for `FdSet` > ([#1107](https://github-redirect.dependabot.com/nix-rust/nix/pull/1107)) > > - Added `NixPath::is_empty`. > ([#1107](https://github-redirect.dependabot.com/nix-rust/nix/pull/1107)) > > - Added `mkfifoat` > ([#1133](https://github-redirect.dependabot.com/nix-rust/nix/pull/1133)) > > - Added `User::from_uid`, `User::from_name`, `User::from_gid` and > `Group::from_name`, > ([#1139](https://github-redirect.dependabot.com/nix-rust/nix/pull/1139)) > > - Added `linkat` > ([#1101](https://github-redirect.dependabot.com/nix-rust/nix/pull/1101)) > > - Added `sched_getaffinity`. > ([#1148](https://github-redirect.dependabot.com/nix-rust/nix/pull/1148)) > > - Added optional `Signal` argument to `ptrace::{detach, syscall}` for signal > injection. ([#1083](https://github-redirect.dependabot.com/nix-rust/nix/pull/1083)) > > ### Changed > - `sys::termios::BaudRate` now implements `TryFrom<speed_t>` instead of > `From<speed_t>`. The old `From` implementation would panic on failure. > ([#1159](https://github-redirect.dependabot.com/nix-rust/nix/pull/1159)) > > - `sys::socket::ControlMessage::ScmCredentials` and > `sys::socket::ControlMessageOwned::ScmCredentials` now wrap `UnixCredentials` > rather than `libc::ucred`. > ([#1160](https://github-redirect.dependabot.com/nix-rust/nix/pull/1160)) > > - `sys::socket::recvmsg` now takes a plain `Vec` instead of a `CmsgBuffer` > implementor. If you were already using `cmsg_space!`, then you needn't worry. > ([#1156](https://github-redirect.dependabot.com/nix-rust/nix/pull/1156)) > > - `sys::socket::recvfrom` now returns > `Result<(usize, Option<SockAddr>)>` instead of `Result<(usize, SockAddr)>`. ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - See full diff in [compare view](https://github.com/nix-rust/nix/commits/v0.16.0) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=nix&package-manager=cargo&previous-version=0.15.0&new-version=0.16.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My apologies, the change that I introduced in #396 failed to consider the generated C header requiring
uchar.hfor thechar32_tdefinition.char32_tis defined as a fundamental type in C++, so I don't believe it's necessary to do the same.As an aside,
char32_tis C11-specific (as already mentioned in #373), will this cause any issues?