Add the ability to automatically derive copy-constructors for tagged enums.#339
Merged
emilio merged 1 commit intomozilla:masterfrom May 10, 2019
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
(Only last commit, the previous is #336) |
mystor
reviewed
May 10, 2019
| write!(out, "default: break;"); | ||
| out.close_brace(false); | ||
| out.close_brace(false); | ||
| } |
There was a problem hiding this comment.
Might be worthwhile to, while here, also generate a T&& constructor.
You'd just need to std::move from the passed-in values, you don't need to change the enum variant or anything like that.
Collaborator
Author
There was a problem hiding this comment.
I think so, though it'd need to be another configuration option (since you may have a non-movable type in the enumeration and you may want a copy-ctor but not a move-ctor, or it may not even compile).
Collaborator
Author
There was a problem hiding this comment.
(So I think I'll defer it for another PR)
emilio
force-pushed
the
tagged-enum-copy-ctor
branch
2 times, most recently
from
69560c5 to
3b14be2
Compare
emilio
force-pushed
the
tagged-enum-copy-ctor
branch
from
3b14be2 to
5861271
Compare
Collaborator
Author
|
I'll call this sanity-checked-by-nika :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful if some of the variants contain non-trivial types, in which case C++ will automatically delete them unless manually implemented.