Output condition for globals.

flaviojs · emilio · commit 316298182ebf · 2024-06-04T00:57:07.000Z
diff --git a/src/bindgen/language_backend/clike.rs b/src/bindgen/language_backend/clike.rs
@@ -770,6 +770,9 @@ impl LanguageBackend for CLikeLanguageBackend<'_> {
     }
 
     fn write_static<W: Write>(&mut self, out: &mut SourceWriter<W>, s: &Static) {
+        let condition = s.cfg.to_condition(self.config);
+        condition.write_before(self.config, out);
+
         self.write_documentation(out, &s.documentation);
         out.write("extern ");
         if let Type::Ptr { is_const: true, .. } = s.ty {
@@ -778,6 +781,8 @@ impl LanguageBackend for CLikeLanguageBackend<'_> {
         }
         cdecl::write_field(self, out, &s.ty, &s.export_name, self.config);
         out.write(";");
+
+        condition.write_after(self.config, out);
     }
 
     fn write_type<W: Write>(&mut self, out: &mut SourceWriter<W>, t: &Type) {
diff --git a/src/bindgen/language_backend/cython.rs b/src/bindgen/language_backend/cython.rs
@@ -315,6 +315,9 @@ impl LanguageBackend for CythonLanguageBackend<'_> {
     }
 
     fn write_static<W: Write>(&mut self, out: &mut SourceWriter<W>, s: &Static) {
+        let condition = s.cfg.to_condition(self.config);
+        condition.write_before(self.config, out);
+
         self.write_documentation(out, &s.documentation);
         out.write("extern ");
         if let Type::Ptr { is_const: true, .. } = s.ty {
@@ -323,6 +326,8 @@ impl LanguageBackend for CythonLanguageBackend<'_> {
         }
         cdecl::write_field(self, out, &s.ty, &s.export_name, self.config);
         out.write(";");
+
+        condition.write_after(self.config, out);
     }
 
     fn write_type<W: Write>(&mut self, out: &mut SourceWriter<W>, t: &Type) {
diff --git a/tests/expectations/cfg.c b/tests/expectations/cfg.c
@@ -83,6 +83,14 @@ typedef struct {
   float y;
 } Normal;
 
+#if defined(PLATFORM_WIN)
+extern int32_t global_array_with_different_sizes[2];
+#endif
+
+#if defined(PLATFORM_UNIX)
+extern int32_t global_array_with_different_sizes[1];
+#endif
+
 #if (defined(PLATFORM_UNIX) && defined(X11))
 void root(FooHandle a, C c);
 #endif
diff --git a/tests/expectations/cfg.compat.c b/tests/expectations/cfg.compat.c
@@ -105,6 +105,14 @@ typedef struct {
 extern "C" {
 #endif // __cplusplus
 
+#if defined(PLATFORM_WIN)
+extern int32_t global_array_with_different_sizes[2];
+#endif
+
+#if defined(PLATFORM_UNIX)
+extern int32_t global_array_with_different_sizes[1];
+#endif
+
 #if (defined(PLATFORM_UNIX) && defined(X11))
 void root(FooHandle a, C c);
 #endif
diff --git a/tests/expectations/cfg.cpp b/tests/expectations/cfg.cpp
@@ -218,6 +218,14 @@ struct Normal {
 
 extern "C" {
 
+#if defined(PLATFORM_WIN)
+extern int32_t global_array_with_different_sizes[2];
+#endif
+
+#if defined(PLATFORM_UNIX)
+extern int32_t global_array_with_different_sizes[1];
+#endif
+
 #if (defined(PLATFORM_UNIX) && defined(X11))
 void root(FooHandle a, C c);
 #endif
diff --git a/tests/expectations/cfg.pyx b/tests/expectations/cfg.pyx
@@ -62,6 +62,12 @@ cdef extern from *:
     int32_t x;
     float y;
 
+  IF PLATFORM_WIN:
+    extern int32_t global_array_with_different_sizes[2];
+
+  IF PLATFORM_UNIX:
+    extern int32_t global_array_with_different_sizes[1];
+
   IF (PLATFORM_UNIX and X11):
     void root(FooHandle a, C c);
 
diff --git a/tests/expectations/cfg_both.c b/tests/expectations/cfg_both.c
@@ -83,6 +83,14 @@ typedef struct Normal {
   float y;
 } Normal;
 
+#if defined(PLATFORM_WIN)
+extern int32_t global_array_with_different_sizes[2];
+#endif
+
+#if defined(PLATFORM_UNIX)
+extern int32_t global_array_with_different_sizes[1];
+#endif
+
 #if (defined(PLATFORM_UNIX) && defined(X11))
 void root(struct FooHandle a, union C c);
 #endif
diff --git a/tests/expectations/cfg_both.compat.c b/tests/expectations/cfg_both.compat.c
@@ -105,6 +105,14 @@ typedef struct Normal {
 extern "C" {
 #endif // __cplusplus
 
+#if defined(PLATFORM_WIN)
+extern int32_t global_array_with_different_sizes[2];
+#endif
+
+#if defined(PLATFORM_UNIX)
+extern int32_t global_array_with_different_sizes[1];
+#endif
+
 #if (defined(PLATFORM_UNIX) && defined(X11))
 void root(struct FooHandle a, union C c);
 #endif
diff --git a/tests/expectations/cfg_tag.c b/tests/expectations/cfg_tag.c
@@ -83,6 +83,14 @@ struct Normal {
   float y;
 };
 
+#if defined(PLATFORM_WIN)
+extern int32_t global_array_with_different_sizes[2];
+#endif
+
+#if defined(PLATFORM_UNIX)
+extern int32_t global_array_with_different_sizes[1];
+#endif
+
 #if (defined(PLATFORM_UNIX) && defined(X11))
 void root(struct FooHandle a, union C c);
 #endif
diff --git a/tests/expectations/cfg_tag.compat.c b/tests/expectations/cfg_tag.compat.c
@@ -105,6 +105,14 @@ struct Normal {
 extern "C" {
 #endif // __cplusplus
 
+#if defined(PLATFORM_WIN)
+extern int32_t global_array_with_different_sizes[2];
+#endif
+
+#if defined(PLATFORM_UNIX)
+extern int32_t global_array_with_different_sizes[1];
+#endif
+
 #if (defined(PLATFORM_UNIX) && defined(X11))
 void root(struct FooHandle a, union C c);
 #endif
diff --git a/tests/expectations/cfg_tag.pyx b/tests/expectations/cfg_tag.pyx
@@ -62,6 +62,12 @@ cdef extern from *:
     int32_t x;
     float y;
 
+  IF PLATFORM_WIN:
+    extern int32_t global_array_with_different_sizes[2];
+
+  IF PLATFORM_UNIX:
+    extern int32_t global_array_with_different_sizes[1];
+
   IF (PLATFORM_UNIX and X11):
     void root(FooHandle a, C c);
 
diff --git a/tests/rust/cfg.rs b/tests/rust/cfg.rs
@@ -76,3 +76,10 @@ extern "C" {
 
     fn bar(a: Normal);
 }
+
+#[cfg(windows)]
+#[no_mangle]
+pub static mut global_array_with_different_sizes: [i32; 2] = [123, 456];
+#[cfg(unix)]
+#[no_mangle]
+pub static mut global_array_with_different_sizes: [i32; 1] = [7890];

Original file line number	Diff line number	Diff line change
`@@ -770,6 +770,9 @@ impl LanguageBackend for CLikeLanguageBackend<'_> {`
`770`	`770`	`}`
`771`	`771`
`772`	`772`	`fn write_static<W: Write>(&mut self, out: &mut SourceWriter<W>, s: &Static) {`
	`773`	`+ let condition = s.cfg.to_condition(self.config);`
	`774`	`+ condition.write_before(self.config, out);`
	`775`	`+`
`773`	`776`	`self.write_documentation(out, &s.documentation);`
`774`	`777`	`out.write("extern ");`
`775`	`778`	`if let Type::Ptr { is_const: true, .. } = s.ty {`
`@@ -778,6 +781,8 @@ impl LanguageBackend for CLikeLanguageBackend<'_> {`
`778`	`781`	`}`
`779`	`782`	`cdecl::write_field(self, out, &s.ty, &s.export_name, self.config);`
`780`	`783`	`out.write(";");`
	`784`	`+`
	`785`	`+ condition.write_after(self.config, out);`
`781`	`786`	`}`
`782`	`787`
`783`	`788`	`fn write_type<W: Write>(&mut self, out: &mut SourceWriter<W>, t: &Type) {`
Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,9 @@ impl LanguageBackend for CythonLanguageBackend<'_> {`
`315`	`315`	`}`
`316`	`316`
`317`	`317`	`fn write_static<W: Write>(&mut self, out: &mut SourceWriter<W>, s: &Static) {`
	`318`	`+ let condition = s.cfg.to_condition(self.config);`
	`319`	`+ condition.write_before(self.config, out);`
	`320`	`+`
`318`	`321`	`self.write_documentation(out, &s.documentation);`
`319`	`322`	`out.write("extern ");`
`320`	`323`	`if let Type::Ptr { is_const: true, .. } = s.ty {`
`@@ -323,6 +326,8 @@ impl LanguageBackend for CythonLanguageBackend<'_> {`
`323`	`326`	`}`
`324`	`327`	`cdecl::write_field(self, out, &s.ty, &s.export_name, self.config);`
`325`	`328`	`out.write(";");`
	`329`	`+`
	`330`	`+ condition.write_after(self.config, out);`
`326`	`331`	`}`
`327`	`332`
`328`	`333`	`fn write_type<W: Write>(&mut self, out: &mut SourceWriter<W>, t: &Type) {`