Fix #421 - don't steal common browser keyboard shortcuts in editor #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Pomax, see if you think this is sane. |
|
is the -L still missing? |
Author
|
Good catch, I've added another commit. |
Author
|
I'm probably not the best person to review this since I don't use keyboard shortcuts too much :P |
Remove Ctrl+L per review
Author
|
I've landed this, let's test it on staging and do follow-ups to improve anything we don't like. One change this introduces is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops us from stealing the common browser shortcuts, and remaps a few useful ones in the editor to use
Altso they still work.