Fix FxA form link contrasts#16128
Merged
Merged
Conversation
wen-2018
added
the
WMO and FXC
maureenlholland
approved these changes
Apr 9, 2025
maureenlholland
left a comment
maureenlholland
left a comment
Collaborator
There was a problem hiding this comment.
r+ ⚡
We should simplify this upstream in protocol, but that will take time. This is a good stop-gap fix. Thanks!
Collaborator
Author
|
I have a protocol fix for its own inheritance, but this here seems to come from more specific refresh colors, redefining the actual protocol theme in the 2024 base locally. Once there's a refresh-themed default in the actual lib, I think similar overrides can be removed. (Actually, in cases like this, it should just include |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel. 🤷 (the promo is included in more places so most likely yes 🔥🦊)One-line summary
Needs more specificity for active, focus, visited inherited from base style.
Significant changes and points to review
Not sure if these are regressions from overriding fonts and colors in base not yet in protocol theme, or was a preexisting issue so I'm not adding any comments to review if/once MZP v20 lands some of that in defaults. Figured being as explicit about (non-)inheritance can't hurt either way.
Issue / Bugzilla link
Resolves #15925
Testing
http://localhost:8000/en/firefox/
http://localhost:8000/en/products/