Refresh: show nav, footer, and banner when translations are available [fix #15570]#15571
Merged
stephaniehobson merged 2 commits intoNov 26, 2024
Merged
Conversation
craigcook
added
P1
stephaniehobson
requested changes
Nov 26, 2024
craigcook
force-pushed
the
15570-m24-nav-footer-logic
branch
from
f6a34e7 to
e9f69a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15571 +/- ##
==========================================
+ Coverage 78.98% 78.99% +0.01%
==========================================
Files 158 158
Lines 8298 8298
==========================================
+ Hits 6554 6555 +1
+ Misses 1744 1743 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Updates the template logic to show global elements when their corresponding Fluent files are active, rather than explicitly for English only.
Issue / Bugzilla link
#15570
Testing
Run
./manage.py l10n_updateto get latest Fluent files, if you haven't lately.Flip switch
M24_WEBSITE_REFRESHonYou should see the nav, footer, and pencil banner on localized pages for most tier 1 languages (I've verified de, fr, es-ES, it, and a few others).
Other locales should fall back to the old content in prod mode (I've been using be and ro to test). In dev mode you'll still see the new elements in English.