Refresh: use Firefox brand fonts on some Firefox pages [fix #15542]#15569
Merged
Conversation
craigcook
added
Needs Review
Collaborator
stephaniehobson
left a comment
stephaniehobson
left a comment
Contributor
There was a problem hiding this comment.
A deceptively easy solution!
I think we should merge #15571 and then rebase this to use the same switches that look for locale activation.
Contributor
Author
Oh good catch, I'll update these as well. |
craigcook
force-pushed
the
15542-m24-firefox-fonts
branch
2 times, most recently
from
bc953ee to
ddd749f
Compare
Contributor
Author
Collaborator
|
To complete the list to test, there's also the non-MDN FXDE WNP (=for older versions): http://localhost:8000/firefox/99.0a2/whatsnew/ |
stephaniehobson
approved these changes
Dec 2, 2024
stephaniehobson
left a comment
stephaniehobson
left a comment
Contributor
There was a problem hiding this comment.
This is working great. The nothing personal page is missing the site_css block. I added it locally and it works fine to once it's added here it's good to merge.
R+ wc
craigcook
force-pushed
the
15542-m24-firefox-fonts
branch
from
ddd749f to
a3b67d1
Compare
whatsnew, welcome, and campaign pages
craigcook
force-pushed
the
15542-m24-firefox-fonts
branch
from
a3b67d1 to
65d28a4
Compare
stephaniehobson
pushed a commit
that referenced
this pull request
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
Keeps Firefox branding on whatsnew, welcome, and campaign pages (mainly for the fonts).
This is admittedly a bit hacky and loads extra fonts so it's a performance hit, but doing it "properly" would probably entail a more significant refactoring of the nav and footer as well as some global styles. We should tackle that at another time.
Issue / Bugzilla link
#15542
Testing
Test a handful of whatsnew and welcome pages with the M24_WEBSITE_REFRESH switch on; make sure the text is rendered in Metropolis and Inter. The footer should use the new Mozilla fonts (only English gets the new footer; other languages get the old footer for now).
http://localhost:8000/firefox/125.0/whatsnew/
http://localhost:8000/firefox/132.0/whatsnew/
http://localhost:8000/firefox/133.0/whatsnew/
http://localhost:8000/firefox/welcome/1/
http://localhost:8000/firefox/welcome/10/
Firefox for Families page; make sure the page body has Metropolis and Inter, and the nav and footer render in Mozilla fonts (and don't otherwise break).
http://localhost:8000/firefox/family/
Nothing Personal page should use Firefox fonts and Mozilla fonts in the footer (this page has no nav):
http://localhost:8000/firefox/nothing-personal/
Challenge the Default page should use Firefox fonts, but this is an odd one because currently it's not available in English but the new Mozilla fonts are English-only. That logic will change soon so this is a pre-emptive strike.
http://localhost:8000/firefox/challenge-the-default/