Add jasmine-browser-runner #13765
Conversation
nathan-barrett
added
Needs Review
|
Few open questions I had while working on this:
|
nathan-barrett
force-pushed
the
13423-jasmine-browser-runner
branch
from
fb5802a to
f1d3077
Compare
alexgibson
left a comment
alexgibson
left a comment
There was a problem hiding this comment.
This is looking great, I'm glad we managed to get it working!
A couple of minor points below, and maybe we can get it to run in Chrome as well using a second config file? Other than that I'm glad this seems to have been less painful then it first seemed :)
| * ``/unit`` contains the Jasmine tests and Karma config file. | ||
| * ``/unit`` contains the Jasmine tests and Jasmine Browser Runner config file. | ||
|
|
||
| Installation |
There was a problem hiding this comment.
Is it worth adding a note in the docs that people will need both geckodriver and chromedriver installed locally before running the tests?
There's already a bit under functional testing that talks about how to install geckodriver: https://bedrock.readthedocs.io/en/latest/testing.html#running-functional-tests
Perhaps we could re-purpose this at the top of the doc, saying both geckodriver and chromedriver are a dependency for running both JS and functional tests locally?
There was a problem hiding this comment.
Yeah, good call out.
|
|
||
| brew install geckodriver | ||
|
|
||
| To download chromedriver and have it ready to run in your system, there are a couple of ways: |
There was a problem hiding this comment.
This all looks good, but it's in the functional tests section of the document, which comes after the Jasmine instructions. Sorry if I wasn't clear, but I was suggesting we could put this information at the top of the file, as a requirement for running both Jasmine and functional tests, so that people would read it before getting to the Jasmine instructions. Does that make sense?
There was a problem hiding this comment.
yup, my mistake!
nathan-barrett
force-pushed
the
13423-jasmine-browser-runner
branch
from
7107ac3 to
78a2bd8
Compare
2 participants
One-line summary
Adding jasmine-browser-runner as a replacement for Karma as the test runner for JS test specs
Significant changes and points to review
Issue / Bugzilla link
#13423
Testing
npm run test