Include required data collection permissions (#5670)

willdurand · web-flow · commit 8a95388303c7 · 2025-05-23T15:31:01.000+02:00
diff --git a/src/schema/imported/manifest.json b/src/schema/imported/manifest.json
@@ -943,6 +943,20 @@
                 ]
               },
               "default": []
+            },
+            "required": {
+              "type": "array",
+              "items": {
+                "allOf": [
+                  {
+                    "$ref": "#/types/DataCollectionPermission"
+                  },
+                  {
+                    "onError": "warn"
+                  }
+                ]
+              },
+              "default": []
             }
           }
         }
diff --git a/src/schema/updates/manifest.json b/src/schema/updates/manifest.json
@@ -15,6 +15,25 @@
           },
           "update_url": {
             "format": "secureUrl"
+          },
+          "data_collection_permissions": {
+            "type": "object",
+            "properties": {
+              "required": {
+                "type": "array",
+                "items": {
+                  "allOf": [
+                    {
+                      "$ref": "#/types/DataCollectionPermission"
+                    },
+                    {
+                      "onError": "warn"
+                    }
+                  ]
+                },
+                "default": []
+              }
+            }
           }
         }
       },
diff --git a/tests/unit/parsers/test.manifestjson.js b/tests/unit/parsers/test.manifestjson.js
@@ -5832,6 +5832,34 @@ describe('ManifestJSONParser', () => {
       expect(manifestJSONParser.isValid).toEqual(false);
     });
 
+    it('validates data collection permissions - unknown required perm', () => {
+      const linter = new Linter({ _: ['bar'] });
+
+      const manifestJSONParser = new ManifestJSONParser(
+        JSON.stringify({
+          manifest_version: 2,
+          name: 'some name',
+          version: '1',
+          browser_specific_settings: {
+            gecko: {
+              data_collection_permissions: {
+                required: ['invalid_perm'],
+              },
+            },
+          },
+        }),
+        linter.collector,
+        { schemaValidatorOptions: { enableDataCollectionPermissions: true } }
+      );
+
+      assertHasMatchingError(linter.collector.errors, {
+        code: messages.JSON_INVALID.code,
+        message:
+          /"\/browser_specific_settings\/gecko\/data_collection_permissions\/required\/0" must be equal to one of the allowed values/,
+      });
+      expect(manifestJSONParser.isValid).toEqual(false);
+    });
+
     it('validates data collection permissions - unknown optional perm', () => {
       const linter = new Linter({ _: ['bar'] });
 

Original file line number	Diff line number	Diff line change
`@@ -943,6 +943,20 @@`
`943`	`943`	`]`
`944`	`944`	`},`
`945`	`945`	`"default": []`
	`946`	`+ },`
	`947`	`+ "required": {`
	`948`	`+ "type": "array",`
	`949`	`+ "items": {`
	`950`	`+ "allOf": [`
	`951`	`+ {`
	`952`	`+ "$ref": "#/types/DataCollectionPermission"`
	`953`	`+ },`
	`954`	`+ {`
	`955`	`+ "onError": "warn"`
	`956`	`+ }`
	`957`	`+ ]`
	`958`	`+ },`
	`959`	`+ "default": []`
`946`	`960`	`}`
`947`	`961`	`}`
`948`	`962`	`}`