Emit an error when data_collection_permissions is specified in the manifest (#5632)

willdurand · web-flow · commit 4e1da4f73d6e · 2025-04-16T17:26:21.000+02:00
diff --git a/docs/index.html b/docs/index.html
@@ -598,6 +598,11 @@ <h2 id="web-extensions-%2F-manifest.json" tabindex="-1">Web Extensions / manifes
 <td>error</td>
 <td>The <code>browser_specific_settings.gecko.admin_install_only</code> property must be set to &quot;true&quot; in an enterprise add-on</td>
 </tr>
+<tr>
+<td><code>DATA_COLLECTION_PERMISSIONS_PROP_RESERVED</code></td>
+<td>error</td>
+<td>The <code>data_collection_permissions</code> property is reserved for future usage and cannot be used in an extension at the moment</td>
+</tr>
 </tbody>
 </table>
 <h3 id="static-theme-%2F-manifest.json" tabindex="-1">Static Theme / manifest.json <a class="header-anchor" href="#static-theme-%2F-manifest.json">¶</a></h3>
diff --git a/docs/rules.md b/docs/rules.md
@@ -137,6 +137,7 @@ Rules are sorted by severity.
 | `INCOGNITO_SPLIT_UNSUPPORTED`                           | warning  | The incognito "split" value is unsupported in Firefox                                                                                                                              |
 | `ADMIN_INSTALL_ONLY_PROP_RESERVED`                      | error    | The `browser_specific_settings.gecko.admin_install_only` property is reserved and can only be used in enterprise add-ons                                                           |
 | `ADMIN_INSTALL_ONLY_REQUIRED`                           | error    | The `browser_specific_settings.gecko.admin_install_only` property must be set to "true" in an enterprise add-on                                                                    |
+| `DATA_COLLECTION_PERMISSIONS_PROP_RESERVED`             | error    | The `data_collection_permissions` property is reserved for future usage and cannot be used in an extension at the moment                                                           |
 
 ### Static Theme / manifest.json
 
diff --git a/src/messages/manifestjson.js b/src/messages/manifestjson.js
@@ -836,3 +836,11 @@ export const ADMIN_INSTALL_ONLY_REQUIRED = {
     in an enterprise add-on.`),
   file: MANIFEST_JSON,
 };
+
+export const DATA_COLLECTION_PERMISSIONS_PROP_RESERVED = {
+  code: 'DATA_COLLECTION_PERMISSIONS_PROP_RESERVED',
+  message: i18n._('The "data_collection_permissions" property is reserved.'),
+  description: i18n._(`The "data_collection_permissions" property is reserved
+    for future usage and cannot be used in an extension at the moment.`),
+  file: MANIFEST_JSON,
+};
diff --git a/src/parsers/manifestjson.js b/src/parsers/manifestjson.js
@@ -538,6 +538,16 @@ export default class ManifestJSONParser extends JSONParser {
       this.isValid = false;
     }
 
+    if (
+      this.parsedJSON.browser_specific_settings?.gecko
+        ?.data_collection_permissions
+    ) {
+      this.collector.addError(
+        messages.DATA_COLLECTION_PERMISSIONS_PROP_RESERVED
+      );
+      this.isValid = false;
+    }
+
     if (this.parsedJSON.content_security_policy != null) {
       this.validateCspPolicy(this.parsedJSON.content_security_policy);
     }
diff --git a/tests/unit/parsers/test.manifestjson.js b/tests/unit/parsers/test.manifestjson.js
@@ -5762,4 +5762,29 @@ describe('ManifestJSONParser', () => {
       }
     );
   });
+
+  describe('data_collection_permissions', () => {
+    it('emits an error when data_collection_permissions is specified', () => {
+      const linter = new Linter({ _: ['bar'] });
+
+      const manifestJSONParser = new ManifestJSONParser(
+        JSON.stringify({
+          manifest_version: 2,
+          name: 'some name',
+          version: '1',
+          browser_specific_settings: {
+            gecko: { data_collection_permissions: {} },
+          },
+        }),
+        linter.collector
+      );
+
+      expect(manifestJSONParser.isValid).toEqual(false);
+      expect(linter.collector.errors).toEqual([
+        expect.objectContaining(
+          messages.DATA_COLLECTION_PERMISSIONS_PROP_RESERVED
+        ),
+      ]);
+    });
+  });
 });
