This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Conditional msg for missing lm.binary added#3435
Merged
reuben merged 1 commit intomozilla:masterfrom Dec 7, 2020
Merged
Conversation
Collaborator
|
@reuben gentle ping? |
Contributor
|
Sorry for forgetting to come back here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error message for an unreadable lm binary file is misleading. We just had a user who wanted to build a scorer with
generate_scorerand got the message "Could not read the scorer file." But he is missing the right lm.binary file. It would therefore be better to state that.@reuben I changed the output to change the msg in case it the the
DS_ERR_SCORER_UNREADABLEmessage. And I haven't been coding C++ for a long time, hope that's fine with you.