Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify encoding usage #366

Merged
merged 1 commit into from
Jan 15, 2019
Merged

clarify encoding usage #366

merged 1 commit into from
Jan 15, 2019

Conversation

maxbeatty
Copy link
Contributor

#363 likely arose from misleading documentation. updating docs and tests to use an encoding besides utf8 that should still parse

@maxbeatty maxbeatty self-assigned this Jan 13, 2019
@jcblw
Copy link
Collaborator

jcblw commented Jan 14, 2019

Looks good! Thanks for the update.

@maxbeatty maxbeatty merged commit 406d0d1 into master Jan 15, 2019
@maxbeatty maxbeatty deleted the encoding-clarification branch January 15, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants