Repository navigation
fix: populate() crashes with TypeError when passed null - #1049
Merged
Merged
Conversation
lbesecker195
approved these changes
Sep 12, 2026
lbesecker195
left a comment
lbesecker195
left a comment
There was a problem hiding this comment.
Verified: typeof null === 'object' slips past the existing check, and processEnv was never validated even though the error message names it. The new guard covers both, and the tests exercise both paths. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
populate(process.env, null)crashes with a rawTypeError. It shouldthrow the
OBJECT_REQUIREDerror, buttypeof null === 'object'passesthe check.
populate(null, parsed)crashes too —processEnvwas neverchecked, even though the error message says to check it.
I fixed the guard to catch null for both arguments. Added two tests.
Tests pass on my machine.