Do not use deprecated datetime.utcnow and datetime.utcfromtimestamp#610
Merged
mosquito merged 2 commits intomosquito:masterfrom Mar 1, 2024
Merged
Do not use deprecated datetime.utcnow and datetime.utcfromtimestamp#610mosquito merged 2 commits intomosquito:masterfrom
mosquito merged 2 commits intomosquito:masterfrom
Conversation
Collaborator
Author
|
Commit e966a96 may be reverted in the future when gmr/pamqp#51 will be released (if it will be merged). |
Alviner
previously approved these changes
Dec 28, 2023
mosquito
reviewed
Dec 29, 2023
Collaborator
Author
|
@mosquito gmr/pamqp#52 was merged and released within version 3.3.0. I think firstly aiormq should be upgraded to pamqp of this new version and after that I can remove commit e966a96 so this PR could be mergeable. |
decaz
force-pushed
the
fix-deprecation-warnings
branch
from
e966a96 to
a1a970b
Compare
mosquito
approved these changes
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change can be breaking because timestamp of incoming message will now have timezone info (UTC by default).
Fixes #609.