contracts/scripts/lido_impl_deploy.ts (3)

1-6: Consider using TypeScript imports consistently.

The code mixes CommonJS (require) and ES6 (import) module systems. Consider using ES6 imports consistently.

-const hre = require("hardhat");
+import { ethers } from "hardhat";
 import 'dotenv/config';
-const { ethers } = hre;

---

9-11: Improve error message specificity.

The current error message "token address invalid" doesn't specify which address is invalid.

-        throw new Error("token address invalid");
+        throw new Error(
+            `Invalid addresses detected:\n${
+                !ethers.utils.isAddress(L1WstETHAddr) ? `- L1WstETH: ${L1WstETHAddr}\n` : ''
+            }${
+                !ethers.utils.isAddress(L2WstETHAddr) ? `- L2WstETH: ${L2WstETHAddr}` : ''
+            }`
+        );

---

16-20: Add deployment verification and event logging.

The deployment process could benefit from additional verification steps and more detailed logging.

     const l1LidoGatewayImpl = await L1LidoGatewayFactory.deploy(L1WstETHAddr, L2WstETHAddr)
     const l2LidoGatewayImpl = await L2LidoGatewayFactory.deploy(L1WstETHAddr, L2WstETHAddr)
+    console.log('Waiting for deployments to complete...')
     await l1LidoGatewayImpl.deployed()
     await l2LidoGatewayImpl.deployed()
-    console.log(`impl deployed l1LidoGatewayImpl ${l1LidoGatewayImpl.address}, l2LidoGatewayImpl ${l2LidoGatewayImpl.address}`)
+    console.log('Deployments completed successfully:')
+    console.log(`- L1LidoGateway Implementation: ${l1LidoGatewayImpl.address}`)
+    console.log(`- L2LidoGateway Implementation: ${l2LidoGatewayImpl.address}`)
+    
+    // Verify contract code is deployed
+    const l1Code = await ethers.provider.getCode(l1LidoGatewayImpl.address)
+    const l2Code = await ethers.provider.getCode(l2LidoGatewayImpl.address)
+    if (l1Code === '0x' || l2Code === '0x') {
+        throw new Error('Contract deployment verification failed')
+    }

contracts/tasks/proxy_upgrade.ts (2)

12-15: Improve error message specificity.

Similar to the deployment script, the error message should specify which address is invalid.

-            throw new Error("token address invalid");
+            throw new Error(
+                `Invalid addresses detected:\n${
+                    !hre.ethers.utils.isAddress(taskArgs.proxyadminaddr) ? `- ProxyAdmin: ${taskArgs.proxyadminaddr}\n` : ''
+                }${
+                    !hre.ethers.utils.isAddress(taskArgs.proxyaddr) ? `- Proxy: ${taskArgs.proxyaddr}\n` : ''
+                }${
+                    !hre.ethers.utils.isAddress(taskArgs.newimpladdr) ? `- New Implementation: ${taskArgs.newimpladdr}` : ''
+                }`
+            );

---

24-29: Add upgrade verification and event logging.

The upgrade process should include additional verification steps and more detailed logging.

         const res = await proxyAdmin.upgrade(taskArgs.proxyaddr, taskArgs.newimpladdr)
         const receipt = await res.wait()
-        console.log(`receipt status : ${receipt.status}`)
+        console.log(`Upgrade transaction status: ${receipt.status ? 'Success' : 'Failed'}`)
+        console.log(`Transaction hash: ${receipt.transactionHash}`)
+        
+        // Verify the implementation was updated
         const newImpl = await proxy.connect(hre.waffle.provider).callStatic.implementation({
             from: taskArgs.proxyadminaddr,
         }))
+        if (newImpl.toLowerCase() !== taskArgs.newimpladdr.toLowerCase()) {
+            throw new Error(
+                `Implementation address mismatch.\nExpected: ${taskArgs.newimpladdr}\nActual: ${newImpl}`
+            )
+        }
+        console.log('Implementation address updated successfully')

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro