fix: Add return value checks for ERC20 transfers in L2Staking#704
Merged
SegueII merged 1 commit intomorph-l2:mainfrom Jan 15, 2025
Merged
fix: Add return value checks for ERC20 transfers in L2Staking#704SegueII merged 1 commit intomorph-l2:mainfrom
SegueII merged 1 commit intomorph-l2:mainfrom
Conversation
This commit adds explicit checks for the return values of ERC20 transfer and transferFrom operations in the L2Staking contract. While the contract already verified balance changes, it didn't check if the initial transfer succeeded. - Add require statement to check transfer() return value - Add require statement to check transferFrom() return value - Improve error messages to be more specific - Maintain existing balance difference checks as additional safety This change follows ERC20 best practices and prevents potential issues with tokens that don't revert on failed transfers.
Contributor
|
MorphToken is our system-level contract, when the transfer fails, it will directly revert and will not return false. At present, there is no vulnerability. |
chengwenxi
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found a potential security vulnerability in the L2Staking contract's _transfer and _transferFrom functions:
The issue is in both transfer functions where they check the balance difference after the transfer. While they verify that the balance increased by the expected amount, they don't check if the initial transfer operation was successful.
This commit adds explicit checks for the return values of ERC20 transfer and transferFrom operations in the L2Staking contract. While the contract already verified balance changes, it didn't check if the initial transfer succeeded.
This change follows ERC20 best practices and prevents potential issues with tokens that don't revert on failed transfers.