fix: address code review feedback

chengwenxi · chengwenxi · commit e5b6f447bc47 · 2026-03-11T13:15:13.000+08:00
- Add comment clarifying proveCommittedBatchState uses eth_call as
  dry-run validation before sending the actual shadow tx
- Skip shadow tx when dry-run validation fails (continue instead of
  falling through)
- Align alloy-primitives version (1.5.6 -&gt; 1.5.7) with Cargo.lock
- Add trailing newline to .gitignore
diff --git a/prover/.gitignore b/prover/.gitignore
@@ -27,4 +27,4 @@ out
 lib
 
 proof
-state
+state
diff --git a/prover/Cargo.toml b/prover/Cargo.toml
@@ -84,7 +84,7 @@ alloy-genesis = { version = "1.6.3", default-features = false, features = [
 ] }
 alloy-json-rpc = { version = "1.6.3", default-features = false }
 alloy-network = { version = "1.6.3", default-features = false }
-alloy-primitives = { version = "1.5.6", default-features = false, features = [
+alloy-primitives = { version = "1.5.7", default-features = false, features = [
     "sha3-keccak",
     "map-hashbrown",
 ] }
diff --git a/prover/bin/shadow-prove/src/shadow_prove.rs b/prover/bin/shadow-prove/src/shadow_prove.rs
@@ -200,19 +200,21 @@ where
 
             log::info!(">Starting prove state onchain, batch index = {:#?}", batch_index);
             let aggr_proof = Bytes::from(prove_result.proof_data);
+            // Dry-run via eth_call to validate the proof before sending the actual shadow tx.
             match self
                 .l1_rollup
                 .proveCommittedBatchState(batch_header.clone(), aggr_proof.clone())
                 .call()
                 .await
             {
                 Ok(_) => log::info!(
-                    "proveCommittedBatchState call success, batch index = {:#?}",
+                    "proveCommittedBatchState dry-run success, batch index = {:#?}",
                     batch_index
                 ),
                 Err(e) => {
-                    log::error!("proveCommittedBatchState call error: {:#?}", e);
+                    log::error!("proveCommittedBatchState dry-run failed: {:#?}", e);
                     METRICS.shadow_verify_result.set(2);
+                    continue;
                 }
             }
             let shadow_tx = self.l1_shadow_rollup.proveState(batch_index, aggr_proof);

-Original file line number
+Diff line change
 lib
 proof
 -state
 +state