remove blob proof generation when making blob (#801)

FletcherMan · fletcher.fan · web-flow · commit 5c3442762cc3 · 2025-11-04T17:22:33.000+08:00
Co-authored-by: fletcher.fan &lt;fletcher.fan@bitget.com&gt;
diff --git a/node/types/blob.go b/node/types/blob.go
@@ -52,7 +52,7 @@ func RetrieveBlobBytes(blob *kzg4844.Blob) ([]byte, error) {
 	return data, nil
 }
 
-func makeBCP(bz []byte) (b kzg4844.Blob, c kzg4844.Commitment, p kzg4844.Proof, err error) {
+func makeBlobCommitment(bz []byte) (b kzg4844.Blob, c kzg4844.Commitment, err error) {
 	blob, err := MakeBlobCanonical(bz)
 	if err != nil {
 		return
@@ -62,10 +62,6 @@ func makeBCP(bz []byte) (b kzg4844.Blob, c kzg4844.Commitment, p kzg4844.Proof,
 	if err != nil {
 		return
 	}
-	p, err = kzg4844.ComputeBlobProof(&b, c)
-	if err != nil {
-		return
-	}
 	return
 }
 
@@ -85,28 +81,26 @@ func MakeBlobTxSidecar(blobBytes []byte) (*eth.BlobTxSidecar, error) {
 		err         error
 		blobs       = make([]kzg4844.Blob, blobCount)
 		commitments = make([]kzg4844.Commitment, blobCount)
-		proofs      = make([]kzg4844.Proof, blobCount)
 	)
 	switch blobCount {
 	case 1:
-		blobs[0], commitments[0], proofs[0], err = makeBCP(blobBytes)
+		blobs[0], commitments[0], err = makeBlobCommitment(blobBytes)
 		if err != nil {
 			return nil, err
 		}
 	case 2:
-		blobs[0], commitments[0], proofs[0], err = makeBCP(blobBytes[:MaxBlobBytesSize])
+		blobs[0], commitments[0], err = makeBlobCommitment(blobBytes[:MaxBlobBytesSize])
 		if err != nil {
 			return nil, err
 		}
-		blobs[1], commitments[1], proofs[1], err = makeBCP(blobBytes[MaxBlobBytesSize:])
+		blobs[1], commitments[1], err = makeBlobCommitment(blobBytes[MaxBlobBytesSize:])
 		if err != nil {
 			return nil, err
 		}
 	}
 	return &eth.BlobTxSidecar{
 		Blobs:       blobs,
 		Commitments: commitments,
-		Proofs:      proofs,
 	}, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ func RetrieveBlobBytes(blob *kzg4844.Blob) ([]byte, error) {`
`52`	`52`	`return data, nil`
`53`	`53`	`}`
`54`	`54`
`55`		`-func makeBCP(bz []byte) (b kzg4844.Blob, c kzg4844.Commitment, p kzg4844.Proof, err error) {`
	`55`	`+func makeBlobCommitment(bz []byte) (b kzg4844.Blob, c kzg4844.Commitment, err error) {`
`56`	`56`	`blob, err := MakeBlobCanonical(bz)`
`57`	`57`	`if err != nil {`
`58`	`58`	`return`
`@@ -62,10 +62,6 @@ func makeBCP(bz []byte) (b kzg4844.Blob, c kzg4844.Commitment, p kzg4844.Proof,`
`62`	`62`	`if err != nil {`
`63`	`63`	`return`
`64`	`64`	`}`
`65`		`- p, err = kzg4844.ComputeBlobProof(&b, c)`
`66`		`- if err != nil {`
`67`		`- return`
`68`		`- }`
`69`	`65`	`return`
`70`	`66`	`}`
`71`	`67`
`@@ -85,28 +81,26 @@ func MakeBlobTxSidecar(blobBytes []byte) (*eth.BlobTxSidecar, error) {`
`85`	`81`	`err error`
`86`	`82`	`blobs = make([]kzg4844.Blob, blobCount)`
`87`	`83`	`commitments = make([]kzg4844.Commitment, blobCount)`
`88`		`- proofs = make([]kzg4844.Proof, blobCount)`
`89`	`84`	`)`
`90`	`85`	`switch blobCount {`
`91`	`86`	`case 1:`
`92`		`- blobs[0], commitments[0], proofs[0], err = makeBCP(blobBytes)`
	`87`	`+ blobs[0], commitments[0], err = makeBlobCommitment(blobBytes)`
`93`	`88`	`if err != nil {`
`94`	`89`	`return nil, err`
`95`	`90`	`}`
`96`	`91`	`case 2:`
`97`		`- blobs[0], commitments[0], proofs[0], err = makeBCP(blobBytes[:MaxBlobBytesSize])`
	`92`	`+ blobs[0], commitments[0], err = makeBlobCommitment(blobBytes[:MaxBlobBytesSize])`
`98`	`93`	`if err != nil {`
`99`	`94`	`return nil, err`
`100`	`95`	`}`
`101`		`- blobs[1], commitments[1], proofs[1], err = makeBCP(blobBytes[MaxBlobBytesSize:])`
	`96`	`+ blobs[1], commitments[1], err = makeBlobCommitment(blobBytes[MaxBlobBytesSize:])`
`102`	`97`	`if err != nil {`
`103`	`98`	`return nil, err`
`104`	`99`	`}`
`105`	`100`	`}`
`106`	`101`	`return &eth.BlobTxSidecar{`
`107`	`102`	`Blobs: blobs,`
`108`	`103`	`Commitments: commitments,`
`109`		`- Proofs: proofs,`
`110`	`104`	`}, nil`
`111`	`105`	`}`
`112`	`106`