Repository navigation
Commit f8b01ae
[opt](build) Repair the BE UT build after the include-edge cuts
The four cut-edge commits on this branch were validated with a -fsyntax-only
sweep over be/src only, so the 1024 be/test TUs were never compiled against the
slimmed graph. A full `ninja -k 0` run (2422 targets) surfaced 8 failing TUs in
4 families. Nothing here restores a cut edge, and no production header gains an
include; the RLE fix in fact tightens the invariant decoder.h already claimed.
- core/wide_integer_from_double.cpp: -Werror,-Wunused-macros. Where the 80-bit
long double exists, wide_integer_impl.h takes its `#if (LDBL_MANT_DIG == 64)`
branch and never evaluates the `#elif defined(...)` that reads
DORIS_WIDE_INTEGER_FROM_DOUBLE_IMPL_TU, so the definition looked unused. The
existing instantiation guard now reads the macro itself. `defined(...)` must
stay the left operand -- the preprocessor short-circuits `&&`, so a false left
term skips it and the warning returns.
- format/parquet/decoder.h and format_v2/parquet/reader/native/decoder.h: outline
BaseDictDecoder's default ctor next to the dtor that was already outlined. A
defaulted-in-class ctor is defined in every TU that constructs a derived
decoder and it odr-uses ~unique_ptr<RleBatchDecoder<uint32_t>>, so the header's
own comment -- that the complete type is only needed in decoder.cpp -- did not
hold. Both trees had the defect; only the format/ one had a test reaching it.
- block_test / column_variant_v2_test: declare the RuntimeProfile and
HybridSorter they use directly. They had been riding
pod_array.h -> thread_context.h and column.h -> exec/sort/hybrid_sorter.h.
- asof_join_test and the two fix_length_dict_decoder tests: include-order-
sensitive, so the cost stays in the tests rather than in a production header.
AsofIndexGroup::sort_and_finalize calls the global pdqsort, which ADL cannot
reach from std::vector's iterators; FixLengthDictDecoder::_decode_values
dereferences a unique_ptr<RleBatchDecoder<uint32_t>> that depends on no
template parameter. Both bind where the template is parsed, not where it is
instantiated, so the supplying include has to come first. The two decoder tests
carry clang-format off/on because the formatter would otherwise sort the
include back after the header under test and break the build again.
Verified: `sh run-be-ut.sh` links test/doris_be_test with 0 failures; all 10
files pass clang-format --dry-run --Werror.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01V3BVeKrPS3jQ2bagcuGHBQ1 parent 624d039 commit f8b01ae
10 files changed
Lines changed: 47 additions & 5 deletions
File tree
- be
- src
- core
- format_v2/parquet/reader/native
- format/parquet
- test
- core
- block
- column
- exec/operator
- format/parquet
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
30 | 37 | | |
31 | 38 | | |
32 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | 97 | | |
99 | | - | |
| 98 | + | |
100 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
101 | 103 | | |
102 | 104 | | |
103 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
131 | 131 | | |
132 | 132 | | |
133 | 133 | | |
134 | | - | |
135 | 134 | | |
136 | 135 | | |
137 | 136 | | |
138 | | - | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
139 | 141 | | |
140 | 142 | | |
141 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
19 | 26 | | |
20 | 27 | | |
21 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
21 | 29 | | |
| 30 | + | |
22 | 31 | | |
23 | 32 | | |
24 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
18 | 26 | | |
| 27 | + | |
19 | 28 | | |
20 | 29 | | |
21 | 30 | | |
| |||
0 commit comments