Repository navigation
Commit e53291d
committed
[fix](binlog) Fence uncertain commit TSO attempts
### What problem does this PR solve?
Issue Number: None
Related PR: apache#67181, apache#67594
Problem Summary: Incremental reads track TSO-bearing commit attempts in FE memory. A commit RPC can finish without a conclusive response, leaving the attempt in the tracker indefinitely, while scanning Meta Service transactions during startup and periodic reconciliation adds complexity and can block unrelated reads. Fence an uncertain attempt in Meta Service before removing its exact TSO from the tracker, release definite responses immediately, and let incremental scans wait for pending lazy commits on their selected partitions. Disable transport retries for TSO-bearing commit RPCs so every uncertain delivery is fenced. Startup calibration advances the same per-instance fence, so stale commits from an old master are rejected without a recovery scan.
### Release note
Bounded incremental reads now fence uncertain commit TSO attempts and no longer require startup or periodic transaction recovery scans.
### Check List (For Author)
- Test: Unit Test
- FE unit tests for TSO tracking, commit response handling, Meta Service retry behavior, and incremental scan version waits
- Cloud unit tests for TSO fence monotonicity, fence-key encoding, and response-code compatibility
- ./build.sh -j32
- ./build.sh --cloud -j32
- Cloud clang-tidy and build hygiene checks
- Behavior changed: Yes. Uncertain TSO commit attempts are fenced before release, definite failures are released directly, and incremental scans wait for selected-partition pending lazy commits.
- Does this need documentation: Yes. Connector-facing error-code documentation is included in the PR description.1 parent 64d601f commit e53291d
22 files changed
Lines changed: 268 additions & 1228 deletions
File tree
- cloud
- src
- common
- meta-service
- test
- fe/fe-core/src
- main/java/org/apache/doris
- cloud
- rpc
- transaction
- metric
- planner
- transaction
- tso
- test/java/org/apache/doris
- cloud
- rpc
- transaction
- planner
- qe
- tso
- gensrc/proto
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
| |||
502 | 501 | | |
503 | 502 | | |
504 | 503 | | |
505 | | - | |
506 | 504 | | |
507 | 505 | | |
508 | 506 | | |
| |||
715 | 713 | | |
716 | 714 | | |
717 | 715 | | |
718 | | - | |
719 | 716 | | |
720 | 717 | | |
721 | 718 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
553 | 553 | | |
554 | 554 | | |
555 | 555 | | |
556 | | - | |
557 | 556 | | |
558 | 557 | | |
559 | 558 | | |
| |||
909 | 908 | | |
910 | 909 | | |
911 | 910 | | |
912 | | - | |
913 | 911 | | |
914 | 912 | | |
915 | 913 | | |
| |||
1055 | 1053 | | |
1056 | 1054 | | |
1057 | 1055 | | |
1058 | | - | |
1059 | 1056 | | |
1060 | 1057 | | |
1061 | 1058 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | 148 | | |
154 | 149 | | |
155 | 150 | | |
| |||
628 | 623 | | |
629 | 624 | | |
630 | 625 | | |
631 | | - | |
632 | | - | |
633 | | - | |
634 | | - | |
635 | | - | |
636 | | - | |
637 | | - | |
638 | | - | |
639 | 626 | | |
640 | 627 | | |
641 | 628 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4835 | 4835 | | |
4836 | 4836 | | |
4837 | 4837 | | |
4838 | | - | |
4839 | | - | |
4840 | | - | |
4841 | | - | |
4842 | | - | |
4843 | | - | |
4844 | | - | |
4845 | | - | |
4846 | | - | |
4847 | | - | |
4848 | | - | |
4849 | | - | |
4850 | | - | |
4851 | | - | |
4852 | | - | |
4853 | | - | |
4854 | | - | |
4855 | | - | |
4856 | | - | |
4857 | | - | |
4858 | | - | |
4859 | | - | |
4860 | | - | |
4861 | | - | |
4862 | | - | |
4863 | | - | |
4864 | | - | |
4865 | | - | |
4866 | | - | |
4867 | | - | |
4868 | | - | |
4869 | | - | |
4870 | | - | |
4871 | | - | |
4872 | | - | |
4873 | | - | |
4874 | | - | |
4875 | | - | |
4876 | | - | |
4877 | | - | |
4878 | | - | |
4879 | | - | |
4880 | | - | |
4881 | | - | |
4882 | | - | |
4883 | | - | |
4884 | | - | |
4885 | | - | |
4886 | | - | |
4887 | | - | |
4888 | | - | |
4889 | | - | |
4890 | | - | |
4891 | | - | |
4892 | | - | |
4893 | | - | |
4894 | | - | |
4895 | | - | |
4896 | | - | |
4897 | | - | |
4898 | | - | |
4899 | | - | |
4900 | | - | |
4901 | | - | |
4902 | | - | |
4903 | | - | |
4904 | | - | |
4905 | | - | |
4906 | | - | |
4907 | | - | |
4908 | | - | |
4909 | | - | |
4910 | | - | |
4911 | | - | |
4912 | | - | |
4913 | | - | |
4914 | | - | |
4915 | | - | |
4916 | | - | |
4917 | | - | |
4918 | | - | |
4919 | | - | |
4920 | | - | |
4921 | | - | |
4922 | | - | |
4923 | | - | |
4924 | | - | |
4925 | | - | |
4926 | | - | |
4927 | | - | |
4928 | | - | |
4929 | | - | |
4930 | | - | |
4931 | | - | |
4932 | | - | |
4933 | | - | |
4934 | | - | |
4935 | | - | |
4936 | | - | |
4937 | | - | |
4938 | | - | |
4939 | | - | |
4940 | 4838 | | |
4941 | 4839 | | |
4942 | 4840 | | |
| |||
0 commit comments