You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 71cfc08
Browse filesBrowse the repository at this point in the historyBrowse files
[chore](fe-core) remove the degenerate DeleteCommandContext + stale migration comments
DeleteCommandContext carried a single field -- a single-valued DeleteFileType enum
(POSITION_DELETE) -- plus a dead toTFileContent() (zero production callers). No branch
ever discriminated on the enum; the value was only threaded through the row-level DML
plan builders, args, and sink nodes and displayed in toString(). Delete the whole class
and un-thread it from RowLevelDmlArgs, DeleteFromCommand, UpdateCommand, the three
ExternalRowLevel*PlanBuilder synthesizers, and the four
Logical/PhysicalExternalRowLevel{Delete,Merge}Sink plan nodes (dropping it from their
constructors, equals/hashCode, and toString). The real FE->BE delete-type is emitted by
the iceberg connector's planWrite (TFileContent.POSITION_DELETES), unaffected.
Also drop the stale internal migration-phase codenames from the row-level DML cluster
comments (P6.6 / T07c / O5-2 / post-flip / post-cutover / pre-cutover) and fix the
RowLevelDmlTransform.handles javadoc that still described the retired table-type check
(it is a connector-capability probe today).
Pure cleanup, no behavior change: compiles clean and the affected unit tests pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01SMtYwYyyubZZiC1odLZTG3
Copy file name to clipboardExpand all lines: fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/LogicalExternalRowLevelDeleteSinkToPhysicalExternalRowLevelDeleteSink.java
Copy file name to clipboardExpand all lines: fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/LogicalExternalRowLevelMergeSinkToPhysicalExternalRowLevelMergeSink.java
Copy file name to clipboardExpand all lines: fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExternalRowLevelDeletePlanBuilder.java
Copy file name to clipboardExpand all lines: fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExternalRowLevelMergePlanBuilder.java
Copy file name to clipboardExpand all lines: fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExternalRowLevelUpdatePlanBuilder.java
0 commit comments