Skip to content

Commit 7097715

Browse files
morningmanclaude
andcommitted
[fix](build) Add missing <condition_variable>/<mutex> includes
Header slimming cut the transitive include chain that used to bring <condition_variable> into global_memory_arbitrator.h on Linux libstdc++ (macOS libc++ provides it transitively via <mutex>/<thread>, which is why local builds passed). Add the std headers each file uses directly; also fix six more headers with the same latent issue. Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent 50a2c72 commit 7097715

7 files changed

Lines changed: 17 additions & 0 deletions

File tree

‎be/src/exec/pipeline/dependency.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include <sqltypes.h>
2929

3030
#include <atomic>
31+
#include <condition_variable>
3132
#include <functional>
3233
#include <memory>
3334
#include <mutex>

‎be/src/exec/rowid_fetcher.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222
#include <gen_cpp/DataSinks_types.h>
2323
#include <gen_cpp/internal_service.pb.h>
2424

25+
#include <condition_variable>
2526
#include <memory>
27+
#include <mutex>
2628
#include <semaphore>
2729
#include <utility>
2830
#include <vector>

‎be/src/exec/scan/task_executor/tools/simulator/simulation_split.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
#include <atomic>
2121
#include <chrono>
22+
#include <condition_variable>
2223
#include <future>
2324
#include <memory>
2425
#include <mutex>

‎be/src/io/cache/block_file_cache.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
#include <array>
2525
#include <atomic>
2626
#include <boost/lockfree/spsc_queue.hpp>
27+
#include <condition_variable>
2728
#include <functional>
2829
#include <limits>
2930
#include <memory>

‎be/src/load/memtable/memtable_memory_limiter.h‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@
1919

2020
#include <stdint.h>
2121

22+
#include <condition_variable>
2223
#include <functional>
24+
#include <memory>
25+
#include <mutex>
2326

2427
#include "common/status.h"
2528
#include "runtime/memory/mem_tracker.h"

‎be/src/runtime/memory/global_memory_arbitrator.h‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@
1717

1818
#pragma once
1919

20+
#include <atomic>
21+
#include <condition_variable>
22+
#include <cstdint>
23+
#include <mutex>
24+
#include <string>
25+
2026
#include "runtime/process_profile.h"
2127
#include "util/mem_info.h"
2228

‎be/src/util/async_io.h‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919

2020
#include <bthread/bthread.h>
2121

22+
#include <condition_variable>
23+
#include <mutex>
24+
2225
#include "io/fs/file_system.h"
2326
#include "runtime/thread_context.h"
2427
#include "storage/olap_define.h"

0 commit comments

Comments
 (0)