Skip to content

Commit 278d3f4

Browse files
morningmanclaude
andcommitted
[chore](fe-core) drop dead aws-java-sdk-dynamodb/logs and bce-java-sdk deps
All three had zero references in fe/**/src and zero transitive consumers (dependency:tree shows dynamodb/logs as fe-core direct-only leaves): - aws-java-sdk-dynamodb / aws-java-sdk-logs (v1): hadoop-aws 3.4.2 no longer ships S3Guard (Hadoop 3.4.0 removed it; the jar contains no DynamoDB class), and the CloudWatch audit destination that the stale "only for apache ranger audit" comment refers to (AmazonCloudWatchAuditDestination) lives in ranger-plugins-audit, which is not on fe-core's classpath (fe-core only pulls ranger-audit-core:2.8.0, whose only destinations are File/base). - bce-java-sdk: BOS object storage is handled via the S3-compatible path (ObjectInfoAdapter 'case BOS' -> S3Properties), so the native Baidu SDK is unused; fe-filesystem does not declare it either. Removing bce-java-sdk also drops its transitive javax.validation:validation-api, which was the only classpath source for the single decorative @NotNull on ExternalMetaIdMgr.replayMetaIdMappingsLog. That annotation is redundant with the Preconditions.checkNotNull(log) on the next line (and is fe-core's only javax.validation usage), so it is removed rather than pulling in a new dependency, keeping fe-core source shrinking only. Parent-pom cleanup of the now-orphaned entries: the mqtt (org.eclipse.paho) management block + mqtt.version property (mqtt was a bce-only transitive), the validation-api management block + property, and the dynamodb/logs version pins. Verified: `test-compile -pl fe-core -am` BUILD SUCCESS (gates pass); resolved dependency:tree confirms the five jars (incl. orphaned mqtt/validation-api) are gone while kept AWS deps (aws-java-sdk-s3 -> kms/core/jmespath) remain. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01SMtYwYyyubZZiC1odLZTG3
1 parent 2ee7479 commit 278d3f4

3 files changed

Lines changed: 4 additions & 58 deletions

File tree

‎fe/fe-core/pom.xml‎

Lines changed: 3 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,9 @@ under the License.
215215
<artifactId>commons-lang3</artifactId>
216216
</dependency>
217217
<!-- Runtime-only: hadoop-huaweicloud's OBSFileSystem (reflection-loaded, so no compile-time
218-
reference reveals this) and bce-java-sdk both call org.apache.commons.lang.StringUtils
219-
while declaring no commons-lang of their own. This declaration is its only source on the
220-
FE classpath; dropping it compiles green and then NoClassDefFoundErrors on OBS access.
218+
reference reveals this) calls org.apache.commons.lang.StringUtils while declaring no
219+
commons-lang of its own. This declaration is its only source on the FE classpath;
220+
dropping it compiles green and then NoClassDefFoundErrors on OBS access.
221221
scope=runtime keeps it off the compile classpath, so fe source stays commons-lang(2.x)-free. -->
222222
<dependency>
223223
<groupId>commons-lang</groupId>
@@ -368,14 +368,6 @@ under the License.
368368
<groupId>com.amazonaws</groupId>
369369
<artifactId>aws-java-sdk-s3</artifactId>
370370
</dependency>
371-
<dependency>
372-
<groupId>com.amazonaws</groupId>
373-
<artifactId>aws-java-sdk-dynamodb</artifactId>
374-
</dependency>
375-
<dependency>
376-
<groupId>com.amazonaws</groupId>
377-
<artifactId>aws-java-sdk-logs</artifactId>
378-
</dependency>
379371
<!-- hadoop-huaweicloud provides OBSFileSystem; loaded via reflection in OBSProperties
380372
with graceful S3A fallback — runtime only, not needed at compile time -->
381373
<dependency>
@@ -551,21 +543,6 @@ under the License.
551543
<artifactId>okhttp-jvm</artifactId>
552544
</dependency>
553545

554-
<dependency>
555-
<groupId>com.baidubce</groupId>
556-
<artifactId>bce-java-sdk</artifactId>
557-
<version>0.10.212</version>
558-
<exclusions>
559-
<exclusion>
560-
<groupId>ch.qos.logback</groupId>
561-
<artifactId>logback-core</artifactId>
562-
</exclusion>
563-
<exclusion>
564-
<groupId>ch.qos.logback</groupId>
565-
<artifactId>logback-classic</artifactId>
566-
</exclusion>
567-
</exclusions>
568-
</dependency>
569546
<dependency>
570547
<groupId>org.apache.ranger</groupId>
571548
<artifactId>ranger-plugins-common</artifactId>

‎fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalMetaIdMgr.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828

2929
import java.util.Map;
3030
import javax.annotation.Nullable;
31-
import javax.validation.constraints.NotNull;
3231

3332
/**
3433
* <pre>
@@ -107,7 +106,7 @@ private PartitionMetaIdMgr getPartitionMetaIdMgr(long catalogId, String dbName,
107106
return tblMetaIdMgr.partitionNameToMgr.get(partitionName);
108107
}
109108

110-
public void replayMetaIdMappingsLog(@NotNull MetaIdMappingsLog log) {
109+
public void replayMetaIdMappingsLog(MetaIdMappingsLog log) {
111110
Preconditions.checkNotNull(log);
112111
long catalogId = log.getCatalogId();
113112
CtlMetaIdMgr ctlMetaIdMgr = idToCtlMgr.computeIfAbsent(catalogId, CtlMetaIdMgr::new);

‎fe/pom.xml‎

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,6 @@ under the License.
296296
<tomcat-embed.version>9.0.104</tomcat-embed.version>
297297
<log4j2.version>2.25.4</log4j2.version>
298298
<log4j-1.2.version>2.25.4</log4j-1.2.version>
299-
<mqtt.version>1.2.5</mqtt.version>
300299
<slf4j.version>2.0.17</slf4j.version>
301300
<metrics-core.version>4.0.2</metrics-core.version>
302301
<!-- Keep Netty compatible with Arrow Flight SQL 19 and other transitive Netty users. -->
@@ -328,7 +327,6 @@ under the License.
328327
<jetty-websocket.version>9.4.58.v20250814</jetty-websocket.version>
329328
<okhttp.version>5.3.2</okhttp.version>
330329
<snakeyaml.version>2.0</snakeyaml.version>
331-
<validation-api.version>2.0.1.Final</validation-api.version>
332330
<zjsonpatch.version>0.2.3</zjsonpatch.version>
333331
<kafka-clients.version>3.4.0</kafka-clients.version>
334332
<oshi-core.version>6.4.5</oshi-core.version>
@@ -1128,17 +1126,6 @@ under the License.
11281126
<artifactId>metrics-core</artifactId>
11291127
<version>${metrics-core.version}</version>
11301128
</dependency>
1131-
<dependency>
1132-
<groupId>org.eclipse.paho</groupId>
1133-
<artifactId>org.eclipse.paho.client.mqttv3</artifactId>
1134-
<version>${mqtt.version}</version>
1135-
<!--
1136-
bce-java-sdk transitively depends on MQTT, but MQTT is not required
1137-
for normal object storage usage. Marked as "provided" to avoid
1138-
unnecessary runtime dependency.
1139-
-->
1140-
<scope>provided</scope>
1141-
</dependency>
11421129
<!-- velocity-engine-core dependency-->
11431130
<dependency>
11441131
<groupId>org.apache.velocity</groupId>
@@ -1264,12 +1251,6 @@ under the License.
12641251
<artifactId>snakeyaml</artifactId>
12651252
<version>${snakeyaml.version}</version>
12661253
</dependency>
1267-
<!-- https://mvnrepository.com/artifact/javax.validation/validation-api -->
1268-
<dependency>
1269-
<groupId>javax.validation</groupId>
1270-
<artifactId>validation-api</artifactId>
1271-
<version>${validation-api.version}</version>
1272-
</dependency>
12731254
<!-- https://mvnrepository.com/artifact/org.slf4j/slf4j-api -->
12741255
<dependency>
12751256
<groupId>org.slf4j</groupId>
@@ -1732,17 +1713,6 @@ under the License.
17321713
<artifactId>aws-java-sdk-glue</artifactId>
17331714
<version>${aws-java-sdk.version}</version>
17341715
</dependency>
1735-
<dependency>
1736-
<groupId>com.amazonaws</groupId>
1737-
<artifactId>aws-java-sdk-dynamodb</artifactId>
1738-
<version>${aws-java-sdk.version}</version>
1739-
</dependency>
1740-
<!--only for apache ranger audit-->
1741-
<dependency>
1742-
<groupId>com.amazonaws</groupId>
1743-
<artifactId>aws-java-sdk-logs</artifactId>
1744-
<version>${aws-java-sdk.version}</version>
1745-
</dependency>
17461716
<dependency>
17471717
<groupId>com.amazonaws</groupId>
17481718
<artifactId>aws-java-sdk-sts</artifactId>

0 commit comments

Comments
 (0)